Hubs/Scopes Merge 26 - Use new API for Kotlin coroutines and SentryWrapper#3351
Merged
Hubs/Scopes Merge 26 - Use new API for Kotlin coroutines and SentryWrapper#3351
Conversation
…pes-merge-2-add-scopes
…ainScopes to rootScopes
adinauer
requested review from
markushi,
romtsn and
stefanosiano
as code owners
Contributor
Instructions and example for changelogPlease add an entry to Example: ## Unreleased
- Hubs/Scopes Merge 26 - Use new API for Kotlin coroutines and SentryWrapper ([#3351](https://github.com/getsentry/sentry-java/pull/3351))If none of the above apply, you can opt out of this check by adding |
markushi
approved these changes
Apr 19, 2024
| assertEquals("c2value", getTag("c2")) | ||
| assertEquals("parentValue", getTag("parent")) | ||
| assertNull(getTag("c1")) | ||
| assertNotNull(getTag("c1")) |
Member
There was a problem hiding this comment.
yes, that's the way it's meant to work. nice!
Member
Author
There was a problem hiding this comment.
We should discuss how this should work in global hub mode. Since Sentry.getCurrentScopes always returns rootScopes (think mainHub) it behaves differently.
Member
Author
There was a problem hiding this comment.
Adding a comment for further discussion on a follow up PR.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
📜 Description
💡 Motivation and Context
💚 How did you test it?
📝 Checklist
sendDefaultPIIis enabled.🔮 Next steps