Conversation
Contributor
|
7 tasks
Contributor
Performance metrics 🚀
|
lbloder
reviewed
Apr 5, 2024
Collaborator
lbloder
left a comment
lbloder
left a comment
There was a problem hiding this comment.
Comment on class EnableSentry refer to Hub instead of Scopes.
Also, should we rename the SentryHubRegistrar and its methods?
sentry-spring/src/main/java/io/sentry/spring/webflux/SentryWebFilter.java
Show resolved
Hide resolved
lbloder
reviewed
Apr 5, 2024
Collaborator
lbloder
left a comment
lbloder
left a comment
There was a problem hiding this comment.
Should we rename HubConfiguration in SentryAutoConfiguration?
|
|
||
| @Bean | ||
| public @NotNull IHub sentryHub( | ||
| public @NotNull IScopes sentryHub( |
Collaborator
There was a problem hiding this comment.
Should we rename this method?
markushi
approved these changes
Apr 15, 2024
markushi
approved these changes
Apr 15, 2024
Base automatically changed from
feat/hsm-10-replacements-in-otel-integration
to
8.x.x
April 16, 2024 14:42
Member
Author
|
We need to test whether renaming Spring beans and config classes breaks anything. Even then user code could break by renaming them. |
adinauer
deleted the
feat/hsm-11-replacements-in-spring-5-boot-2-integrations
branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
#skip-changelog
📜 Description
Follow up for #3297 changing Spring 5 / Spring Boot 2 integrations.
💡 Motivation and Context
💚 How did you test it?
📝 Checklist
sendDefaultPIIis enabled.🔮 Next steps