Ensure performance measurement collection is not taken too frequently#3221
Merged
Conversation
…llections compiled regex in AndroidCpuCollector to parse the cpu file, to improve speed
stefanosiano
marked this pull request as ready for review
February 22, 2024 15:40
stefanosiano
requested review from
adinauer,
markushi and
romtsn
as code owners
February 22, 2024 15:40
Contributor
Author
|
Do we need a changelog entry for this change? |
Contributor
Performance metrics 🚀
|
| Revision | Plain | With Sentry | Diff |
|---|---|---|---|
| 4bf95dd | 345.96 ms | 414.24 ms | 68.28 ms |
| 95a98b5 | 380.06 ms | 453.56 ms | 73.50 ms |
| 2465853 | 400.64 ms | 465.47 ms | 64.83 ms |
| 7ab32b6 | 373.62 ms | 480.61 ms | 106.99 ms |
| 2fad834 | 390.07 ms | 470.80 ms | 80.73 ms |
| 1f3652d | 361.62 ms | 424.76 ms | 63.14 ms |
| 937879e | 400.98 ms | 482.84 ms | 81.86 ms |
| 4e29063 | 376.38 ms | 390.98 ms | 14.60 ms |
| 4e260b3 | 388.40 ms | 468.98 ms | 80.58 ms |
| 86f0096 | 368.63 ms | 446.92 ms | 78.29 ms |
App size
| Revision | Plain | With Sentry | Diff |
|---|---|---|---|
| 4bf95dd | 1.72 MiB | 2.29 MiB | 576.40 KiB |
| 95a98b5 | 1.70 MiB | 2.27 MiB | 586.31 KiB |
| 2465853 | 1.70 MiB | 2.27 MiB | 583.82 KiB |
| 7ab32b6 | 1.70 MiB | 2.27 MiB | 584.63 KiB |
| 2fad834 | 1.72 MiB | 2.29 MiB | 577.53 KiB |
| 1f3652d | 1.72 MiB | 2.27 MiB | 554.95 KiB |
| 937879e | 1.72 MiB | 2.27 MiB | 558.42 KiB |
| 4e29063 | 1.72 MiB | 2.29 MiB | 578.38 KiB |
| 4e260b3 | 1.72 MiB | 2.27 MiB | 554.95 KiB |
| 86f0096 | 1.72 MiB | 2.29 MiB | 576.50 KiB |
romtsn
approved these changes
Feb 23, 2024
romtsn
left a comment
romtsn
left a comment
Member
There was a problem hiding this comment.
nice!
Do we need a changelog entry for this change?
Yeah ideally we'd mention something, especially when it touches production code 👍
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
📜 Description
performance measurement collection now waits at least 10ms between collections
compiled regex in AndroidCpuCollector to parse the cpu file, to improve speed
💡 Motivation and Context
Some UI tests are failing. Also, measurements taken too quickly (1ms) caused issues when the backend parsed the data. It was resolved in the backend, but it's something we should avoid in the first place
💚 How did you test it?
📝 Checklist
sendDefaultPIIis enabled.🔮 Next steps