Skip to content

Add support for measurements at span level#3219

Merged
stefanosiano merged 9 commits into
mainfrom
feat/span-level-measurement
Feb 28, 2024
Merged

Add support for measurements at span level#3219
stefanosiano merged 9 commits into
mainfrom
feat/span-level-measurement

Conversation

@stefanosiano

@stefanosiano stefanosiano commented Feb 22, 2024 •
edited by martinhaintz
Loading

Copy link
Copy Markdown
Contributor

spans forward measurements to transaction

📜 Description

added measurements to spans
spans forward measurements to transaction
Example transaction

💡 Motivation and Context

Fixes #3180

💚 How did you test it?

Unit tests

📝 Checklist

  • I reviewed the submitted code.
  • I added tests to verify the changes.
  • No new PII added or SDK only sends newly added PII if sendDefaultPII is enabled.
  • I updated the docs if needed.
  • Review from the native team if needed.
  • No breaking change or entry added to the changelog.
  • No breaking change for hybrid SDKs or communicated to hybrid SDKs.

🔮 Next steps

@stefanosiano
added measurements to spans
e0944c2 
spans forward measurements to transaction
@stefanosiano
fixed tests
4dabf57
@github-actions

github-actions Bot commented Feb 22, 2024 •
edited
Loading

Copy link
Copy Markdown
Contributor
Fails
🚫 Please consider adding a changelog entry for the next release.
Messages
📖 Do not forget to update Sentry-docs with your feature once the pull request gets approved.

Instructions and example for changelog

Please add an entry to CHANGELOG.md to the "Unreleased" section. Make sure the entry includes this PR's number.

Example:

## Unreleased

- Add support for measurements at span level ([#3219](https://github.com/getsentry/sentry-java/pull/3219))

If none of the above apply, you can opt out of this check by adding #skip-changelog to the PR description.

Generated by 🚫 dangerJS against 32460b3

@stefanosiano stefanosiano changed the title Add measurements at span level Add support for measurements at span level Feb 22, 2024
@stefanosiano
stefanosiano marked this pull request as ready for review February 22, 2024 14:14
@github-actions

github-actions Bot commented Feb 22, 2024 •
edited
Loading

Copy link
Copy Markdown
Contributor

Performance metrics 🚀

  Plain With Sentry Diff
Startup time 428.22 ms 538.29 ms 110.06 ms
Size 1.70 MiB 2.28 MiB 590.71 KiB

Baseline results on branch: main

Startup times

Revision Plain With Sentry Diff
0810952 364.51 ms 468.08 ms 103.57 ms
2fad834 390.07 ms 470.80 ms 80.73 ms
2465853 422.61 ms 491.20 ms 68.58 ms
8ff8fd0 432.77 ms 495.18 ms 62.41 ms
2465853 400.64 ms 465.47 ms 64.83 ms
5e04ee8 365.26 ms 448.49 ms 83.23 ms
c554ca2 368.52 ms 430.74 ms 62.22 ms
4e29063 384.14 ms 447.74 ms 63.60 ms
0404ea3 394.73 ms 461.79 ms 67.06 ms
0404ea3 332.47 ms 401.12 ms 68.66 ms

App size

Revision Plain With Sentry Diff
0810952 1.72 MiB 2.27 MiB 558.21 KiB
2fad834 1.72 MiB 2.29 MiB 577.53 KiB
2465853 1.70 MiB 2.27 MiB 583.82 KiB
8ff8fd0 1.72 MiB 2.27 MiB 558.15 KiB
2465853 1.70 MiB 2.27 MiB 583.82 KiB
5e04ee8 1.70 MiB 2.27 MiB 584.64 KiB
c554ca2 1.70 MiB 2.27 MiB 582.25 KiB
4e29063 1.72 MiB 2.29 MiB 578.38 KiB
0404ea3 1.72 MiB 2.29 MiB 577.52 KiB
0404ea3 1.72 MiB 2.29 MiB 577.52 KiB

Previous results on branch: feat/span-level-measurement

Startup times

Revision Plain With Sentry Diff
ead0785 492.72 ms 628.02 ms 135.30 ms
268afc3 407.69 ms 470.34 ms 62.65 ms

App size

Revision Plain With Sentry Diff
ead0785 1.70 MiB 2.28 MiB 587.99 KiB
268afc3 1.70 MiB 2.28 MiB 588.33 KiB

markushi
markushi reviewed Feb 22, 2024
View reviewed changes

@markushi markushi left a comment •
edited
Loading

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice one, l left a few comments mainly for discussion

Comment thread sentry/src/main/java/io/sentry/Span.java
Comment thread sentry/src/main/java/io/sentry/Span.java Outdated
Comment thread sentry/src/main/java/io/sentry/protocol/SentryTransaction.java
Comment thread sentry/src/main/java/io/sentry/Span.java Outdated
romtsn
romtsn reviewed Feb 23, 2024
View reviewed changes
Comment thread sentry/src/main/java/io/sentry/protocol/SentrySpan.java Outdated
@stefanosiano stefanosiano mentioned this pull request Feb 26, 2024
Closed
@stefanosiano
Merge branch 'main' into feat/span-level-measurement
4912d48 
# Conflicts:
#	CHANGELOG.md
#	sentry-android-core/src/main/java/io/sentry/android/core/PerformanceAndroidEventProcessor.java
@stefanosiano
added SentryTracer.setMeasurementFromChild method to avoid overwritin…
afde400 
…g measurements when coming from the children
markushi
markushi approved these changes Feb 28, 2024
View reviewed changes

@markushi markushi left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@stefanosiano
stefanosiano merged commit 7275aa8 into main Feb 28, 2024
@stefanosiano
stefanosiano deleted the feat/span-level-measurement branch February 28, 2024 14:48
@stefanosiano stefanosiano mentioned this pull request Apr 18, 2024
Closed
@buenaflor buenaflor mentioned this pull request Aug 1, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@markushi markushi markushi approved these changes
@adinauer adinauer Awaiting requested review from adinauer adinauer is a code owner
@romtsn romtsn Awaiting requested review from romtsn romtsn is a code owner

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Support span level measurements

3 participants

@stefanosiano @markushi @romtsn