Resolve spring properties in @SentryCheckIn annotation#3194
Merged
Conversation
lbloder
requested review from
adinauer,
markushi,
romtsn and
stefanosiano
as code owners
February 6, 2024 09:49
Contributor
|
Contributor
Performance metrics 🚀
|
| Revision | Plain | With Sentry | Diff |
|---|---|---|---|
| 93a76ca | 381.08 ms | 459.22 ms | 78.14 ms |
| b7fa26f | 440.10 ms | 533.98 ms | 93.88 ms |
| 1f3652d | 367.21 ms | 438.46 ms | 71.25 ms |
| 86f0096 | 368.63 ms | 446.92 ms | 78.29 ms |
| 7eccfdb | 389.94 ms | 461.29 ms | 71.35 ms |
| d6d2b2e | 392.55 ms | 467.50 ms | 74.95 ms |
| d6d2b2e | 463.14 ms | 545.56 ms | 82.42 ms |
| c7e2fbc | 372.00 ms | 461.71 ms | 89.71 ms |
| 8838e01 | 387.41 ms | 467.00 ms | 79.59 ms |
| eecfab6 | 399.27 ms | 461.82 ms | 62.55 ms |
App size
| Revision | Plain | With Sentry | Diff |
|---|---|---|---|
| 93a76ca | 1.72 MiB | 2.29 MiB | 576.75 KiB |
| b7fa26f | 1.70 MiB | 2.27 MiB | 583.82 KiB |
| 1f3652d | 1.72 MiB | 2.27 MiB | 554.95 KiB |
| 86f0096 | 1.72 MiB | 2.29 MiB | 576.50 KiB |
| 7eccfdb | 1.72 MiB | 2.27 MiB | 556.93 KiB |
| d6d2b2e | 1.72 MiB | 2.27 MiB | 555.05 KiB |
| d6d2b2e | 1.72 MiB | 2.27 MiB | 555.05 KiB |
| c7e2fbc | 1.72 MiB | 2.29 MiB | 576.40 KiB |
| 8838e01 | 1.72 MiB | 2.29 MiB | 578.15 KiB |
| eecfab6 | 1.72 MiB | 2.27 MiB | 558.56 KiB |
Previous results on branch: feat/resolve-spring-props-checkin
Startup times
| Revision | Plain | With Sentry | Diff |
|---|---|---|---|
| 0ea3997 | 427.34 ms | 457.58 ms | 30.24 ms |
| a0d22c6 | 401.86 ms | 493.76 ms | 91.90 ms |
| 617ebd3 | 438.64 ms | 530.44 ms | 91.80 ms |
App size
| Revision | Plain | With Sentry | Diff |
|---|---|---|---|
| 0ea3997 | 1.70 MiB | 2.27 MiB | 584.64 KiB |
| a0d22c6 | 1.70 MiB | 2.27 MiB | 584.64 KiB |
| 617ebd3 | 1.70 MiB | 2.27 MiB | 584.64 KiB |
adinauer
reviewed
Feb 6, 2024
adinauer
reviewed
Feb 7, 2024
adinauer
reviewed
Feb 7, 2024
…heckin/SentryCheckInAdvice.java Co-authored-by: Alexander Dinauer <[email protected]>
…try/sentry-java into feat/resolve-spring-props-checkin # Conflicts: # sentry-spring-jakarta/src/main/java/io/sentry/spring/jakarta/checkin/SentryCheckInAdvice.java
romtsn
approved these changes
Feb 13, 2024
# Conflicts: # CHANGELOG.md
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
📜 Description
Allow for dynamic monitor slugs in
@SentryCheckInannotation by resolving spring properties as well as raw strings.Now it is possible to do
@SentryCheckin("${my.property}")withmy.propertybeing replaced by spring.💡 Motivation and Context
Fixes #3191
💚 How did you test it?
📝 Checklist
sendDefaultPIIis enabled.🔮 Next steps