[Starfish] Attach app start spans to app.start.cold txn#3067
Merged
markushi merged 9 commits intofeat/app-start-spansfrom Dec 12, 2023
Merged
[Starfish] Attach app start spans to app.start.cold txn#3067markushi merged 9 commits intofeat/app-start-spansfrom
markushi merged 9 commits intofeat/app-start-spansfrom
Conversation
markushi
requested review from
adinauer,
romtsn and
stefanosiano
as code owners
Contributor
|
Contributor
Performance metrics 🚀
|
| Revision | Plain | With Sentry | Diff |
|---|---|---|---|
| 3751e60 | 414.69 ms | 454.45 ms | 39.76 ms |
| 3fd1e60 | 390.54 ms | 446.90 ms | 56.36 ms |
| 5f1218e | 408.20 ms | 466.26 ms | 58.06 ms |
| 6cd4f31 | 389.94 ms | 445.81 ms | 55.87 ms |
App size
| Revision | Plain | With Sentry | Diff |
|---|---|---|---|
| 3751e60 | 1.72 MiB | 2.27 MiB | 557.10 KiB |
| 3fd1e60 | 1.72 MiB | 2.27 MiB | 557.21 KiB |
| 5f1218e | 1.72 MiB | 2.29 MiB | 580.44 KiB |
| 6cd4f31 | 1.72 MiB | 2.27 MiB | 557.15 KiB |
Previous results on branch: feat/app-start-txn-op
Startup times
| Revision | Plain | With Sentry | Diff |
|---|---|---|---|
| 85a0313 | 375.58 ms | 451.96 ms | 76.38 ms |
| 028e7b7 | 394.98 ms | 462.18 ms | 67.20 ms |
| fcb2fe4 | 330.79 ms | 443.21 ms | 112.43 ms |
| 1af8231 | 607.73 ms | 731.96 ms | 124.22 ms |
App size
| Revision | Plain | With Sentry | Diff |
|---|---|---|---|
| 85a0313 | 1.72 MiB | 2.29 MiB | 580.57 KiB |
| 028e7b7 | 1.72 MiB | 2.27 MiB | 557.29 KiB |
| fcb2fe4 | 1.72 MiB | 2.27 MiB | 556.98 KiB |
| 1af8231 | 1.72 MiB | 2.27 MiB | 556.84 KiB |
markushi
changed the title
Comment on lines
244
to
246
| transactionOp = APP_START_COLD; | ||
| } else if (Boolean.FALSE.equals(coldStart)) { | ||
| transactionOp = APP_START_WARM; |
romtsn
approved these changes
Dec 4, 2023
Member
|
Related Cocoa issue getsentry/sentry-cocoa#3466. |
…ava into feat/app-start-txn-op
markushi
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
📜 Description
Starfish only: Use app.start.* for cold/warm start transaction opStarfish only: Attach app start spans (
ContentProvider.onCreate,Application.onCreate,Activity.onCreate,Activity.onStart) to the app start transaction.#skip-changelog
💡 Motivation and Context
Fixes parts of getsentry/team-sdks#22
💚 How did you test it?
Added unit tests
📝 Checklist
sendDefaultPIIis enabled.🔮 Next steps