7.0.0#2958
Merged
Merged
Conversation
Co-authored-by: Sentry Github Bot <[email protected]> Co-authored-by: Roman Zavarnitsyn <[email protected]>
* reduced timeout of AsyncHttpTransport close to flushTimeoutMillis (default 4s in Android and 15s in Java) to avoid ANRs in Android
* Add deadline timeout for automatic transactions * Update Changelog * Address PR comments * Fix formatting * Add missing test, improve naming * Ensure deadline timeout is only set once
* updated minimum Android SDK version to 19 * removed few workarounds for version < 19
Co-authored-by: Roman Zavarnitsyn <[email protected]> Co-authored-by: Sentry Github Bot <[email protected]>
Contributor
|
Co-authored-by: Roman Zavarnitsyn <[email protected]>
romtsn
marked this pull request as ready for review
November 27, 2023 16:13
romtsn
requested review from
adinauer,
markushi and
stefanosiano
as code owners
November 27, 2023 16:13
kahest
reviewed
Nov 27, 2023
kahest
left a comment
kahest
left a comment
Contributor
There was a problem hiding this comment.
great update, and great release notes 🥔🥔🥔🥔🥔
left some thoughts that also apply to the migration docs
3 tasks
markushi
approved these changes
Nov 28, 2023
* execute withScopeCallback in noopHub, add tests to SentryTest * extract IScope interface * initial migration to IScope * fix usages of IScope constructor and replace with Scope, add fromScope static Method, fix tests, add tests, run withScope even on disabled hub * replace static fromScope method with clone * add changelog entries * revert unintended changes * Format code --------- Co-authored-by: Sentry Github Bot <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
8 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
#skip-changelog
📜 Description
💡 Motivation and Context
💚 How did you test it?
📝 Checklist
sendDefaultPIIis enabled.🔮 Next steps