Conversation
removed few workarounds for version < 19
Contributor
|
Contributor
Performance metrics 🚀
|
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## feat/7.0.0 #2883 +/- ##
================================================
+ Coverage 81.26% 81.45% +0.19%
- Complexity 4560 4661 +101
================================================
Files 350 354 +4
Lines 16866 17155 +289
Branches 2272 2321 +49
================================================
+ Hits 13706 13974 +268
- Misses 2219 2231 +12
- Partials 941 950 +9
☔ View full report in Codecov by Sentry. |
stefanosiano
requested review from
adinauer,
markushi and
romtsn
as code owners
markushi
approved these changes
Aug 8, 2023
sentry-android-core/src/main/java/io/sentry/android/core/internal/util/ScreenshotUtils.java
Outdated
Show resolved
Hide resolved
Closed
marandaneto
reviewed
Aug 17, 2023
| val minSdkVersion = 19 | ||
| val minSdkVersionOkHttp = 21 | ||
| val minSdkVersionNdk = 16 | ||
| val minSdkVersionNdk = 19 |
Contributor
There was a problem hiding this comment.
minSdkVersionNdk can be removed since its the same now.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
📜 Description
updated minimum Android SDK version to 19
removed few workarounds for version < 19
💡 Motivation and Context
Fixes #2126
💚 How did you test it?
📝 Checklist
sendDefaultPIIis enabled.🔮 Next steps