Skip to content

Comments

Add autoconfigure modules for Spring Boot called sentry-spring-boot and sentry-spring-boot-jakarta#2880

Merged
adinauer merged 3 commits intomainfrom
feat/spring-autoconfigure-modules
Aug 4, 2023
Merged

Add autoconfigure modules for Spring Boot called sentry-spring-boot and sentry-spring-boot-jakarta#2880
adinauer merged 3 commits intomainfrom
feat/spring-autoconfigure-modules

Conversation

@adinauer
Copy link
Member

@adinauer adinauer commented Aug 3, 2023 •
edited
Loading

📜 Description

Rename sentry-spring-boot-starter to sentry-spring-boot which is now our "autoconfigure" module that has a compileOnly dependency on spring-boot-starter. Add a new sentry-spring-boot-starter module that depends on sentry-spring-boot as well as spring-boot-starter. Same changes for jakarta packages.

💡 Motivation and Context

Fixes #2866

💚 How did you test it?

Manually

📝 Checklist

  • I reviewed the submitted code.
  • I added tests to verify the changes.
  • No new PII added or SDK only sends newly added PII if sendDefaultPII is enabled.
  • I updated the docs if needed.
  • Review from the native team if needed.
  • No breaking change or entry added to the changelog.
  • No breaking change for hybrid SDKs or communicated to hybrid SDKs.

🔮 Next steps

@adinauer
Move sentry-spring-boot-starter to sentry-spring-boot module and have…
28c3064 
… sentry-spring-boot-starter bring spring-boot-starter
@adinauer adinauer requested a review from lbloder August 3, 2023 12:24
@adinauer adinauer changed the title Move sentry-spring-boot-starter to sentry-spring-boot module and have… Add autoconfigure modules for Spring Boot called sentry-spring-boot and sentry-spring-boot-jakarta Aug 3, 2023
@github-actions
Copy link
Contributor

github-actions bot commented Aug 3, 2023 •
edited
Loading

Messages
📖 Do not forget to update Sentry-docs with your feature once the pull request gets approved.

Generated by 🚫 dangerJS against b0c4588

@github-actions
Copy link
Contributor

github-actions bot commented Aug 3, 2023 •
edited
Loading

Performance metrics 🚀

  Plain With Sentry Diff
Startup time 314.90 ms 364.52 ms 49.62 ms
Size 1.72 MiB 2.29 MiB 575.70 KiB

Baseline results on branch: main

Startup times

Revision Plain With Sentry Diff
496bdfd 301.22 ms 343.96 ms 42.73 ms
fe10f05 314.71 ms 360.62 ms 45.90 ms
fe10f05 304.13 ms 365.65 ms 61.52 ms
f60279b 324.60 ms 345.33 ms 20.73 ms
496bdfd 272.86 ms 407.33 ms 134.48 ms
9246ed4 275.63 ms 321.31 ms 45.69 ms
87b3774 310.48 ms 362.04 ms 51.56 ms
4bf202b 331.20 ms 345.24 ms 14.04 ms
fe10f05 294.30 ms 346.84 ms 52.54 ms
4c237f8 319.84 ms 354.47 ms 34.63 ms

App size

Revision Plain With Sentry Diff
496bdfd 1.72 MiB 2.28 MiB 571.82 KiB
fe10f05 1.72 MiB 2.29 MiB 575.54 KiB
fe10f05 1.72 MiB 2.29 MiB 575.54 KiB
f60279b 1.72 MiB 2.29 MiB 575.23 KiB
496bdfd 1.72 MiB 2.28 MiB 571.82 KiB
9246ed4 1.72 MiB 2.28 MiB 572.22 KiB
87b3774 1.72 MiB 2.29 MiB 575.54 KiB
4bf202b 1.72 MiB 2.29 MiB 575.54 KiB
fe10f05 1.72 MiB 2.29 MiB 575.54 KiB
4c237f8 1.72 MiB 2.29 MiB 575.58 KiB

Previous results on branch: feat/spring-autoconfigure-modules

Startup times

Revision Plain With Sentry Diff
248b0ed 317.16 ms 350.24 ms 33.08 ms
cf38672 294.44 ms 338.49 ms 44.05 ms

App size

Revision Plain With Sentry Diff
248b0ed 1.72 MiB 2.29 MiB 575.70 KiB
cf38672 1.72 MiB 2.29 MiB 575.70 KiB

@adinauer adinauer mentioned this pull request Aug 3, 2023
Merged
@codecov
Copy link

codecov bot commented Aug 3, 2023 •
edited
Loading

Codecov Report

Patch and project coverage have no change.

Comparison is base (fb296f0) 80.45% compared to head (17e8ccb) 80.45%.

❗ Current head 17e8ccb differs from pull request most recent head b0c4588. Consider uploading reports for the commit b0c4588 to get more accurate results

Additional details and impacted files 
@@            Coverage Diff            @@
##               main    #2880   +/-   ##
=========================================
  Coverage     80.45%   80.45%           
  Complexity     4701     4701           
=========================================
  Files           371      371           
  Lines         17556    17556           
  Branches       2364     2364           
=========================================
  Hits          14125    14125           
  Misses         2454     2454           
  Partials        977      977
Files Changed Coverage Δ
...try/spring/boot/jakarta/InAppIncludesResolver.java 80.00% <ø> (ø)
...y/spring/boot/jakarta/SentryAutoConfiguration.java 97.14% <ø> (ø)
...akarta/SentryLogbackAppenderAutoConfiguration.java 100.00% <ø> (ø)
.../spring/boot/jakarta/SentryLogbackInitializer.java 96.87% <ø> (ø)
...o/sentry/spring/boot/jakarta/SentryProperties.java 80.00% <ø> (ø)
...boot/jakarta/SentrySpanRestTemplateCustomizer.java 100.00% <ø> (ø)
...ng/boot/jakarta/SentrySpanWebClientCustomizer.java 100.00% <ø> (ø)
...g/boot/jakarta/SentryWebfluxAutoConfiguration.java 85.71% <ø> (ø)
...a/io/sentry/spring/boot/InAppIncludesResolver.java 80.00% <ø> (ø)
...io/sentry/spring/boot/SentryAutoConfiguration.java 97.14% <ø> (ø)
... and 6 more

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

lbloder
lbloder approved these changes Aug 4, 2023
View reviewed changes
Copy link
Collaborator

@lbloder lbloder left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

So, existing users of the spring-boot integration would need to change their dependency from sentry-spring-boot -starter to just sentry-spring-boot, correct?

@adinauer adinauer mentioned this pull request Aug 4, 2023
Merged
7 tasks
@adinauer
Copy link
Member Author

adinauer commented Aug 4, 2023

So, existing users of the spring-boot integration would need to change their dependency from sentry-spring-boot -starter to just sentry-spring-boot, correct?

It should work with either the starter or the autoconfigure (e.g. sentry-spring-boot) for existing users as build tools should be able to figure this out.

@adinauer adinauer enabled auto-merge (squash) August 4, 2023 07:18
@adinauer adinauer merged commit 7cdf121 into main Aug 4, 2023
@adinauer adinauer deleted the feat/spring-autoconfigure-modules branch August 4, 2023 07:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@lbloder lbloder lbloder approved these changes

@romtsn romtsn Awaiting requested review from romtsn romtsn is a code owner

@stefanosiano stefanosiano Awaiting requested review from stefanosiano

@markushi markushi Awaiting requested review from markushi markushi is a code owner

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Spring Boot starter does not bring spring-boot-starter

2 participants

@adinauer @lbloder