Skip to content

Comments

Measure AppStart time till First Draw #2851

Merged
romtsn merged 5 commits intofeat/7.0.0from
rz/fix/app-start-span-first-draw
Jul 25, 2023
Merged

Measure AppStart time till First Draw #2851
romtsn merged 5 commits intofeat/7.0.0from
rz/fix/app-start-span-first-draw

Conversation

@romtsn
Copy link
Member

@romtsn romtsn commented Jul 19, 2023

📜 Description

  • Moves setting AppStart end time to First Draw listener in both ActivityLifecycleIntegration and SentryPerformanceProvider

image

💡 Motivation and Context

Closes #2627

💚 How did you test it?

Manually and automated

📝 Checklist

  • I reviewed the submitted code.
  • I added tests to verify the changes.
  • No new PII added or SDK only sends newly added PII if sendDefaultPII is enabled.
  • I updated the docs if needed.
  • Review from the native team if needed.
  • No breaking change or entry added to the changelog.
  • No breaking change for hybrid SDKs or communicated to hybrid SDKs.

🔮 Next steps

@romtsn romtsn changed the title Move enableNdk to SentryAndroidOptions (#2793) Report AppStart end time on First Draw Jul 19, 2023
@romtsn romtsn changed the title Report AppStart end time on First Draw Measure AppStart time till First Draw Jul 19, 2023
@github-actions
Copy link
Contributor

github-actions bot commented Jul 19, 2023 •
edited
Loading

Performance metrics 🚀

  Plain With Sentry Diff
Startup time 300.76 ms 365.22 ms 64.46 ms
Size 1.72 MiB 2.29 MiB 575.86 KiB

Previous results on branch: rz/fix/app-start-span-first-draw

Startup times

Revision Plain With Sentry Diff
8e39f54 288.38 ms 312.52 ms 24.14 ms
d181251 315.49 ms 325.49 ms 10.00 ms

App size

Revision Plain With Sentry Diff
8e39f54 1.72 MiB 2.29 MiB 575.49 KiB
d181251 1.72 MiB 2.29 MiB 575.49 KiB

@codecov
Copy link

codecov bot commented Jul 19, 2023 •
edited
Loading

Codecov Report

Patch coverage: 86.28% and project coverage change: +0.15% 🎉

Comparison is base (9020d1b) 81.26% compared to head (c5c2ad6) 81.41%.

Additional details and impacted files 
@@               Coverage Diff                @@
##             feat/7.0.0    #2851      +/-   ##
================================================
+ Coverage         81.26%   81.41%   +0.15%     
- Complexity         4560     4644      +84     
================================================
  Files               350      354       +4     
  Lines             16866    17106     +240     
  Branches           2272     2313      +41     
================================================
+ Hits              13706    13927     +221     
- Misses             2219     2230      +11     
- Partials            941      949       +8
Files Changed Coverage Δ
...racing/SentrySpanClientHttpRequestInterceptor.java 0.00% <0.00%> (ø)
...ebflux/SentryWebFilterWithThreadLocalAccessor.java 0.00% <0.00%> (ø)
...racing/SentrySpanClientHttpRequestInterceptor.java 0.00% <0.00%> (ø)
sentry/src/main/java/io/sentry/Breadcrumb.java 85.04% <ø> (ø)
sentry/src/main/java/io/sentry/HostnameCache.java 90.69% <ø> (ø)
sentry/src/main/java/io/sentry/Hub.java 75.17% <ø> (ø)
.../src/main/java/io/sentry/JsonObjectSerializer.java 84.21% <ø> (ø)
...ry/src/main/java/io/sentry/ProfilingTraceData.java 78.51% <ø> (ø)
.../main/java/io/sentry/ProfilingTransactionData.java 52.52% <ø> (ø)
sentry/src/main/java/io/sentry/Scope.java 96.72% <0.00%> (-0.36%) ⬇️
... and 80 more

... and 1 file with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

stefanosiano
stefanosiano approved these changes Jul 24, 2023
View reviewed changes
Copy link
Contributor

@stefanosiano stefanosiano left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

everything looks good
i was thinking to add the considerations in https://blog.p-y.wtf/tracking-android-app-launch-in-production#heading-cold-launch-1, since sometime (rarely) the start timestamp we get is wrong and we are changing the related code
We can do that in another pr, too

@romtsn
Copy link
Member Author

romtsn commented Jul 24, 2023

everything looks good i was thinking to add the considerations in blog.p-y.wtf/tracking-android-app-launch-in-production#heading-cold-launch-1, since sometime (rarely) the start timestamp we get is wrong and we are changing the related code We can do that in another pr, too

yes, I'd do it in a separate PR, and we also have an issue for that specifically #2177

@romtsn romtsn merged commit 1c0c691 into feat/7.0.0 Jul 25, 2023
@romtsn romtsn deleted the rz/fix/app-start-span-first-draw branch July 25, 2023 17:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@adinauer adinauer Awaiting requested review from adinauer

@markushi markushi Awaiting requested review from markushi

1 more reviewer

@stefanosiano stefanosiano stefanosiano approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@romtsn @stefanosiano