Merged
Conversation
Member
Author
|
The only problem is that this change is binary-incompatible, so if someone is using an older integration version (e.g. |
Contributor
Performance metrics 🚀
|
stefanosiano
approved these changes
Jul 25, 2023
Contributor
stefanosiano
left a comment
stefanosiano
left a comment
There was a problem hiding this comment.
looks great!
just a note, though. The public interfaces that were changed are technically a breaking change. A note in the changelog is enough, as it will be part of v7 anyway
markushi
approved these changes
Aug 8, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
📜 Description
Since sentry-unity consumes Android SDK artifacts decoupled from each other (e.g.
sentry.jarandsentry-android-core.aardo not know about each other), some versions of Unity cannot properly desugardefaultmethods in interfaces during build time.This results in runtime errors when a
defaultmethod fromsentry.jaris called insentry-android-core.aar. We've tried to work this around by properly consuming android artifacts using local maven (#2725), but this turned out to be a nightmare to support, because we modify gradle build files via regexes on sentry-unity.This PR simply converts all
defaultmethods that are used in sentry-android-core to be non-default (meaning proper implementations in each interface implementor).💡 Motivation and Context
@bitsandfoxes mental well-being
💚 How did you test it?
Manually and automated
📝 Checklist
sendDefaultPIIis enabled.🔮 Next steps