Encode/Decode internal apollo3 headers#2707
Merged
Merged
Conversation
Contributor
Performance metrics 🚀
|
| Revision | Plain | With Sentry | Diff |
|---|---|---|---|
| d9bd3b7 | 314.76 ms | 355.60 ms | 40.84 ms |
| 3ecfb25 | 301.62 ms | 368.38 ms | 66.76 ms |
| bccb1ad | 314.51 ms | 380.98 ms | 66.47 ms |
App size
| Revision | Plain | With Sentry | Diff |
|---|---|---|---|
| d9bd3b7 | 1.72 MiB | 2.28 MiB | 565.45 KiB |
| 3ecfb25 | 1.72 MiB | 2.28 MiB | 570.00 KiB |
| bccb1ad | 1.72 MiB | 2.28 MiB | 570.00 KiB |
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## main #2707 +/- ##
============================================
- Coverage 81.11% 81.11% -0.01%
- Complexity 4445 4447 +2
============================================
Files 345 345
Lines 16387 16394 +7
Branches 2226 2226
============================================
+ Hits 13293 13298 +5
- Misses 2166 2168 +2
Partials 928 928
☔ View full report in Codecov by Sentry. |
lbloder
changed the title
lbloder
marked this pull request as ready for review
May 11, 2023 13:26
lbloder
requested review from
adinauer,
markushi,
romtsn and
stefanosiano
as code owners
May 11, 2023 13:26
adinauer
reviewed
May 12, 2023
adinauer
left a comment
adinauer
left a comment
Member
There was a problem hiding this comment.
Mostly LGTM. I think we should should handle decode exceptions directly in code, not sure Apollo fails the request if we throw out.
# Conflicts: # CHANGELOG.md
# Conflicts: # CHANGELOG.md
adinauer
approved these changes
May 19, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
📜 Description
Base64 encode/decode internal apollo3 headers
💡 Motivation and Context
Fixes #2680
💚 How did you test it?
📝 Checklist
sendDefaultPIIis enabled.🔮 Next steps