Skip to content

Fix remove saucelab config name attribute, as it does not exist anymore#2677

Merged
markushi merged 4 commits into
mainfrom
fix/saucelabs-config-files
May 26, 2023
Merged

Fix remove saucelab config name attribute, as it does not exist anymore#2677
markushi merged 4 commits into
mainfrom
fix/saucelabs-config-files

Conversation

@markushi

Copy link
Copy Markdown
Member

Use build attribute instead which describes which module was used to run the tests.

#skip-changelog

@codecov

codecov Bot commented Apr 26, 2023

Copy link
Copy Markdown

Codecov Report

Patch and project coverage have no change.

Comparison is base (46e0307) 81.11% compared to head (7b0d24c) 81.11%.

Additional details and impacted files
@@            Coverage Diff            @@
##               main    #2677   +/-   ##
=========================================
  Coverage     81.11%   81.11%           
  Complexity     4449     4449           
=========================================
  Files           345      345           
  Lines         16407    16407           
  Branches       2226     2226           
=========================================
  Hits          13308    13308           
  Misses         2172     2172           
  Partials        927      927           

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@markushi markushi changed the title Fix remove name attribute, as it does not exist anymore Fix remove saucelab config name attribute, as it does not exist anymore Apr 26, 2023
Comment thread .sauce/sentry-uitest-android-benchmark-lite.yml Outdated
@stefanosiano

Copy link
Copy Markdown
Contributor

Would it be possible to do something like this sample, if it's worth it? wdyt?

@markushi
markushi requested a review from stefanosiano May 26, 2023 06:36
@markushi
markushi merged commit 37cd75a into main May 26, 2023
@markushi
markushi deleted the fix/saucelabs-config-files branch May 26, 2023 08:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants