Trim time-to-full-display span if reportFullyDisplayed API is never called#2631
Merged
Conversation
exposed `getFinishDate` internally in ISpan
stefanosiano
marked this pull request as ready for review
March 29, 2023 09:27
stefanosiano
requested review from
adinauer,
markushi and
romtsn
as code owners
March 29, 2023 09:27
Contributor
Performance metrics 🚀
|
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## main #2631 +/- ##
=========================================
Coverage 81.37% 81.37%
- Complexity 4219 4221 +2
=========================================
Files 337 337
Lines 15599 15601 +2
Branches 2037 2037
=========================================
+ Hits 12693 12695 +2
Misses 2111 2111
Partials 795 795
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report in Codecov by Sentry. |
markushi
approved these changes
Mar 30, 2023
aligned with cocoa for " - Deadline Exceeded" suffix
aligned with cocoa for " - Deadline Exceeded" suffix
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
📜 Description
ttfd span is trimmed if
reportFullyDisplayedAPI is never calledexposed
getFinishDateinternally in ISpan💡 Motivation and Context
Currently if the user enables the option to track the fullDisplay, the transaction keeps running and if the manual API is never called, the
time-to-full-displayspan would always last 30 seconds, increasing the transaction duration.This change aims to mitigate this issue, so that if no other spans are present, the total transaction duration would be until the
time-to-initial-displayspan is finished.💚 How did you test it?
Unit test
📝 Checklist
sendDefaultPIIis enabled.🔮 Next steps