Skip to content

Add 6.0.0 requirements for hosted Sentry#2628

Merged
romtsn merged 3 commits into
getsentry:mainfrom
dirtyhenry:update-compat
Mar 28, 2023
Merged

Add 6.0.0 requirements for hosted Sentry#2628
romtsn merged 3 commits into
getsentry:mainfrom
dirtyhenry:update-compat

Conversation

@dirtyhenry

@dirtyhenry dirtyhenry commented Mar 28, 2023

Copy link
Copy Markdown
Contributor

#skip-changelog

📜 Description

Before bumping the Sentry SDK of my Android app, I had a hard time figuring out if the SDK version was compatible with the hosted Sentry version I was going to use.

💡 Motivation and Context

After digging through release notes, I stumbled on this note:

Starting with version 6.0.0 of the sentry package, Sentry's self hosted version >= v21.9.0 is required or you have to manually disable sending client reports via the sendClientReports option. This only applies to self-hosted Sentry.

I assume this is information that should belong to the main README, shouldn't it?

💚 How did you test it?

I proofread the MD 😉

📝 Checklist

  • I reviewed the submitted code.
  • I added tests to verify the changes.
  • No new PII added or SDK only sends newly added PII if sendDefaultPII is enabled.
  • I updated the docs if needed.
  • Review from the native team if needed.
  • No breaking change or entry added to the changelog.
  • No breaking change for hybrid SDKs or communicated to hybrid SDKs.

🔮 Next steps

This PR only contains what I actually found reading release notes but I can't be sure I haven't missed other similar notes for other versions of the SDK.

Comment thread README.md Outdated
Comment thread README.md Outdated

@romtsn romtsn left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I assume this is information that should belong to the main README, shouldn't it?

@dirtyhenry absolutely! thank you for the contrib and sorry for the time wasted on searching for this info.

We'll probably have to introduce a compatibility table with the next entry for better readability, but for now it's good enough.

@romtsn
romtsn merged commit 70c2097 into getsentry:main Mar 28, 2023
@dirtyhenry
dirtyhenry deleted the update-compat branch March 28, 2023 11:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants