Fix Automatic UI transactions having wrong durations#2623
Merged
Conversation
…not appStart span is present Span now trims for all transaction children if it's the root span of the transaction
stefanosiano
marked this pull request as ready for review
March 24, 2023 17:34
stefanosiano
requested review from
adinauer,
markushi and
romtsn
as code owners
March 24, 2023 17:34
Contributor
Performance metrics 🚀
|
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## main #2623 +/- ##
============================================
+ Coverage 81.31% 81.32% +0.01%
- Complexity 4187 4192 +5
============================================
Files 336 336
Lines 15485 15489 +4
Branches 2020 2021 +1
============================================
+ Hits 12591 12597 +6
+ Misses 2101 2099 -2
Partials 793 793
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report in Codecov by Sentry. |
markushi
approved these changes
Mar 27, 2023
| @Nullable SentryDate maxChildEnd = null; | ||
|
|
||
| final @NotNull List<Span> children = getChildren(); | ||
| // The root span should be trimmed based on all children, but the other spans, like the |
Member
There was a problem hiding this comment.
love this, explains the "why" really good and will make it easier to re-iterate over this in future.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
📜 Description
Automatic Activity transactions now have the ttid start timestamp if appStart span is not present
Span now trims for all transaction children if it's the root span of the transaction
💡 Motivation and Context
The reported duration of the transaction is wrong.
💚 How did you test it?
Added Unit tests
📝 Checklist
sendDefaultPIIis enabled.🔮 Next steps