Provide CPU count/frequency data as device context#2622
Merged
Conversation
markushi
requested review from
adinauer,
romtsn and
stefanosiano
as code owners
March 24, 2023 13:04
Contributor
|
Contributor
Performance metrics 🚀
|
| Revision | Plain | With Sentry | Diff |
|---|---|---|---|
| d81684e | 235.73 ms | 328.76 ms | 93.03 ms |
App size
| Revision | Plain | With Sentry | Diff |
|---|---|---|---|
| d81684e | 1.73 MiB | 2.26 MiB | 547.78 KiB |
Previous results on branch: feat/cpu-info-for-device-context
Startup times
| Revision | Plain | With Sentry | Diff |
|---|---|---|---|
| b87c189 | 277.96 ms | 333.42 ms | 55.46 ms |
| d39f310 | 301.85 ms | 341.92 ms | 40.07 ms |
| 5d9e93d | 326.30 ms | 352.68 ms | 26.38 ms |
| b2056ee | 282.14 ms | 340.54 ms | 58.40 ms |
App size
| Revision | Plain | With Sentry | Diff |
|---|---|---|---|
| b87c189 | 1.73 MiB | 2.26 MiB | 548.06 KiB |
| d39f310 | 1.73 MiB | 2.26 MiB | 548.06 KiB |
| 5d9e93d | 1.73 MiB | 2.26 MiB | 548.23 KiB |
| b2056ee | 1.73 MiB | 2.26 MiB | 548.75 KiB |
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## main #2622 +/- ##
============================================
+ Coverage 81.34% 81.37% +0.02%
- Complexity 4211 4219 +8
============================================
Files 337 337
Lines 15575 15599 +24
Branches 2034 2037 +3
============================================
+ Hits 12670 12693 +23
- Misses 2110 2111 +1
Partials 795 795
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report in Codecov by Sentry. |
Member
Author
|
Waiting for feedback, see getsentry/team-mobile#77 (comment) |
stefanosiano
approved these changes
Mar 28, 2023
stefanosiano
left a comment
stefanosiano
left a comment
Contributor
There was a problem hiding this comment.
looks good, just a couple minor comments
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
📜 Description
Adds CPU description, processor count and frequency to the device context.
💡 Motivation and Context
Implements required changes for #2561
💚 How did you test it?
📝 Checklist
sendDefaultPIIis enabled.🔮 Next steps