Pass through unknown sentry baggage keys into SentryEnvelopeHeader#2618
Merged
Conversation
adinauer
requested review from
markushi,
romtsn and
stefanosiano
as code owners
March 22, 2023 11:39
Contributor
|
Contributor
Performance metrics 🚀
|
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## main #2618 +/- ##
============================================
+ Coverage 81.32% 81.34% +0.01%
- Complexity 4192 4211 +19
============================================
Files 336 337 +1
Lines 15489 15575 +86
Branches 2021 2034 +13
============================================
+ Hits 12597 12670 +73
- Misses 2099 2110 +11
- Partials 793 795 +2
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report in Codecov by Sentry. |
antonpirker
approved these changes
Mar 27, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
📜 Description
When converting
BaggagetoTraceContextalso keep unknown keys prefixed withsentry-and send them to Sentry viaSentryEnvelopeHeader.💡 Motivation and Context
So we don't have to add every new key explicitly and instead simply pass through all unknown keys.
💚 How did you test it?
Unit Tests, manually using Sample
📝 Checklist
sendDefaultPIIis enabled.🔮 Next steps