Add time-to-initial-display and time-to-full-display measurements to Activity transactions#2611
Merged
Merged
Conversation
added getStartDate() to ISpan fixed ActivityLifecycleIntegration tests
Contributor
|
stefanosiano
changed the title
Contributor
Performance metrics 🚀
|
| Revision | Plain | With Sentry | Diff |
|---|---|---|---|
| d81684e | 235.73 ms | 328.76 ms | 93.03 ms |
App size
| Revision | Plain | With Sentry | Diff |
|---|---|---|---|
| d81684e | 1.73 MiB | 2.26 MiB | 547.78 KiB |
Previous results on branch: feat/ttid-tffd-measurements
Startup times
| Revision | Plain | With Sentry | Diff |
|---|---|---|---|
| 97f2094 | 448.31 ms | 498.76 ms | 50.45 ms |
| 55a1e65 | 311.44 ms | 339.21 ms | 27.77 ms |
| 6939df1 | 311.71 ms | 389.82 ms | 78.11 ms |
App size
| Revision | Plain | With Sentry | Diff |
|---|---|---|---|
| 97f2094 | 1.73 MiB | 2.26 MiB | 548.02 KiB |
| 55a1e65 | 1.73 MiB | 2.26 MiB | 548.03 KiB |
| 6939df1 | 1.73 MiB | 2.26 MiB | 547.98 KiB |
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## main #2611 +/- ##
=========================================
Coverage 81.31% 81.31%
- Complexity 4187 4189 +2
=========================================
Files 336 336
Lines 15485 15487 +2
Branches 2020 2020
=========================================
+ Hits 12591 12593 +2
Misses 2101 2101
Partials 793 793
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report in Codecov by Sentry. |
stefanosiano
marked this pull request as ready for review
March 17, 2023 16:58
stefanosiano
requested review from
adinauer,
markushi and
romtsn
as code owners
March 17, 2023 16:58
romtsn
reviewed
Mar 21, 2023
romtsn
reviewed
Mar 21, 2023
romtsn
approved these changes
Mar 21, 2023
romtsn
left a comment
romtsn
left a comment
Member
There was a problem hiding this comment.
a couple of minor comments, but LGTM 🚀
changed duration measurements to milliseconds
romtsn
reviewed
Mar 22, 2023
removed measurement keys magic strings from tests
Member
|
checked again, looking good |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
📜 Description
Added ttid and ttfd as measurements
Added getStartDate() to ISpan
Fixed ActivityLifecycleIntegration tests
💡 Motivation and Context
Currently we track time-to-initial-display and time-to-full-display as spans on automatic activity transactions.
Now we add them as measurements, too.
More info here.
💚 How did you test it?
Unit tests
📝 Checklist
sendDefaultPIIis enabled.🔮 Next steps