Skip to content

Fix wrong default environment in Session#2610

Merged
lbloder merged 5 commits into
mainfrom
feat/default_environment
Mar 22, 2023
Merged

Fix wrong default environment in Session#2610
lbloder merged 5 commits into
mainfrom
feat/default_environment

Conversation

@lbloder

@lbloder lbloder commented Mar 17, 2023 •
edited
Loading

Copy link
Copy Markdown
Collaborator

📜 Description

The environment getter in SentryOptions now returns "production" as default if not set.

💡 Motivation and Context

Fixes #2381

💚 How did you test it?

📝 Checklist

  • I reviewed the submitted code.
  • I added tests to verify the changes.
  • No new PII added or SDK only sends newly added PII if sendDefaultPII is enabled.
  • I updated the docs if needed.
  • Review from the native team if needed.
  • No breaking change or entry added to the changelog.
  • No breaking change for hybrid SDKs or communicated to hybrid SDKs.

🔮 Next steps

@github-actions

github-actions Bot commented Mar 17, 2023 •
edited
Loading

Copy link
Copy Markdown
Contributor
Messages
📖 Do not forget to update Sentry-docs with your feature once the pull request gets approved.

Generated by 🚫 dangerJS against 4ed1f71

@lbloder lbloder changed the title Default value for environment in SentryOptions Fix wrong default environment in Session Mar 17, 2023
@github-actions

github-actions Bot commented Mar 17, 2023 •
edited
Loading

Copy link
Copy Markdown
Contributor

Performance metrics 🚀

  Plain With Sentry Diff
Startup time 331.45 ms 399.00 ms 67.55 ms
Size 1.73 MiB 2.26 MiB 547.63 KiB

Previous results on branch: feat/default_environment

Startup times

Revision Plain With Sentry Diff
fe1d2d7 328.68 ms 385.94 ms 57.26 ms
1dd523f 387.79 ms 423.14 ms 35.35 ms

App size

Revision Plain With Sentry Diff
fe1d2d7 1.73 MiB 2.26 MiB 547.63 KiB
1dd523f 1.73 MiB 2.26 MiB 547.63 KiB

romtsn
romtsn reviewed Mar 21, 2023
View reviewed changes
Comment thread sentry/src/main/java/io/sentry/SentryOptions.java Outdated
@codecov

codecov Bot commented Mar 22, 2023 •
edited
Loading

Copy link
Copy Markdown

Codecov Report

Patch coverage: 100.00% and project coverage change: -0.01 ⚠️

Comparison is base (db18794) 81.31% compared to head (4ed1f71) 81.31%.

Additional details and impacted files 
@@             Coverage Diff              @@
##               main    #2610      +/-   ##
============================================
- Coverage     81.31%   81.31%   -0.01%     
  Complexity     4187     4187              
============================================
  Files           336      336              
  Lines         15486    15485       -1     
  Branches       2021     2020       -1     
============================================
- Hits          12592    12591       -1     
  Misses         2101     2101              
  Partials        793      793
Impacted Files Coverage Δ
...ry/src/main/java/io/sentry/MainEventProcessor.java 85.41% <100.00%> (-0.11%) ⬇️
sentry/src/main/java/io/sentry/SentryOptions.java 80.43% <100.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@lbloder
lbloder marked this pull request as ready for review March 22, 2023 14:42
@lbloder
lbloder merged commit 8ec2c16 into main Mar 22, 2023
@lbloder
lbloder deleted the feat/default_environment branch March 22, 2023 15:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@adinauer adinauer adinauer approved these changes
@romtsn romtsn romtsn approved these changes
@stefanosiano stefanosiano Awaiting requested review from stefanosiano
@markushi markushi Awaiting requested review from markushi markushi is a code owner

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

sessions sent without an environment when environment option is not set - Android

3 participants

@lbloder @adinauer @romtsn