Add breadcrumbs on network changes#2608
Merged
Merged
Conversation
added registerNetworkCallback and unregisterNetworkCallback to ConnectivityChecker added io.sentry.breadcrumbs.network-events manifest option added enableNetworkEventBreadcrumbs manual option
Contributor
|
Contributor
Performance metrics 🚀
|
| Revision | Plain | With Sentry | Diff |
|---|---|---|---|
| d81684e | 235.73 ms | 328.76 ms | 93.03 ms |
| 17ab223 | 427.65 ms | 484.31 ms | 56.65 ms |
App size
| Revision | Plain | With Sentry | Diff |
|---|---|---|---|
| d81684e | 1.73 MiB | 2.26 MiB | 547.78 KiB |
| 17ab223 | 1.73 MiB | 2.34 MiB | 626.85 KiB |
Previous results on branch: feat/android-network-breadcrumbs
Startup times
| Revision | Plain | With Sentry | Diff |
|---|---|---|---|
| 7d71474 | 289.92 ms | 353.24 ms | 63.32 ms |
| 66c90cd | 330.26 ms | 369.08 ms | 38.82 ms |
| 39fb59f | 344.72 ms | 394.45 ms | 49.73 ms |
| d503c14 | 372.30 ms | 445.20 ms | 72.90 ms |
App size
| Revision | Plain | With Sentry | Diff |
|---|---|---|---|
| 7d71474 | 1.73 MiB | 2.26 MiB | 549.85 KiB |
| 66c90cd | 1.73 MiB | 2.26 MiB | 550.21 KiB |
| 39fb59f | 1.73 MiB | 2.26 MiB | 549.85 KiB |
| d503c14 | 1.73 MiB | 2.34 MiB | 628.09 KiB |
Codecov ReportPatch and project coverage have no change.
Additional details and impacted files@@ Coverage Diff @@
## main #2608 +/- ##
=========================================
Coverage 81.37% 81.37%
Complexity 4219 4219
=========================================
Files 337 337
Lines 15599 15599
Branches 2037 2037
=========================================
Hits 12693 12693
Misses 2111 2111
Partials 795 795
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report in Codecov by Sentry. |
stefanosiano
marked this pull request as ready for review
March 17, 2023 16:58
stefanosiano
requested review from
adinauer,
markushi and
romtsn
as code owners
March 17, 2023 16:58
romtsn
reviewed
Mar 28, 2023
romtsn
reviewed
Mar 28, 2023
romtsn
reviewed
Mar 28, 2023
romtsn
approved these changes
Mar 28, 2023
romtsn
left a comment
romtsn
left a comment
Member
There was a problem hiding this comment.
great stuff 👍 a couple of minor things, but lgtm otherwise
# Conflicts: # CHANGELOG.md
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
📜 Description
added NetworkBreadcrumbsIntegration
added registerNetworkCallback and unregisterNetworkCallback to ConnectivityChecker
added io.sentry.breadcrumbs.network-events manifest option
added enableNetworkEventBreadcrumbs manual option
💡 Motivation and Context
In order to provide more context to the user when an error occurs or during a transaction, we are adding breadcrumbs on network changes, like when a vpn is enabled or disabled or the device connects/disconnects to/from a network.
💚 How did you test it?
Unit tests
📝 Checklist
sendDefaultPIIis enabled.🔮 Next steps
Connection details (vpn status, up/down bandwidth and signal strength) is collected correctly and set as a Hint of the breadcrumbs. I should add these details to the breadcrumb data, too