Add name and geo to User#2556
Merged
Merged
Conversation
Contributor
|
denrase
marked this pull request as ready for review
February 21, 2023 10:29
denrase
requested review from
adinauer,
markushi,
romtsn and
stefanosiano
as code owners
February 21, 2023 10:29
denrase
requested review from
philipphofmann
and removed request for
adinauer,
markushi,
romtsn and
stefanosiano
February 21, 2023 10:29
Contributor
Performance metrics 🚀
|
| Revision | Plain | With Sentry | Diff |
|---|---|---|---|
| d81684e | 235.73 ms | 328.76 ms | 93.03 ms |
App size
| Revision | Plain | With Sentry | Diff |
|---|---|---|---|
| d81684e | 1.73 MiB | 2.26 MiB | 547.78 KiB |
Previous results on branch: feat/user-name-and-geo
Startup times
| Revision | Plain | With Sentry | Diff |
|---|---|---|---|
| 96e2af6 | 412.22 ms | 432.49 ms | 20.26 ms |
| 87bd976 | 341.90 ms | 446.66 ms | 104.76 ms |
| 061e3dd | 329.84 ms | 393.36 ms | 63.52 ms |
| 2686d20 | 362.39 ms | 393.20 ms | 30.81 ms |
| 8b36629 | 344.80 ms | 381.90 ms | 37.10 ms |
App size
| Revision | Plain | With Sentry | Diff |
|---|---|---|---|
| 96e2af6 | 1.73 MiB | 2.34 MiB | 626.19 KiB |
| 87bd976 | 1.73 MiB | 2.34 MiB | 626.56 KiB |
| 061e3dd | 1.73 MiB | 2.34 MiB | 626.62 KiB |
| 2686d20 | 1.73 MiB | 2.34 MiB | 626.73 KiB |
| 8b36629 | 1.73 MiB | 2.34 MiB | 626.76 KiB |
Member
|
@denrase, did you tag me for review for a specific reason? If not, Roman or Markus could also have a look at this PR. |
markushi
reviewed
Feb 23, 2023
markushi
requested changes
Feb 23, 2023
markushi
left a comment
markushi
left a comment
Member
There was a problem hiding this comment.
Looking great, thanks for contributing - please have a look at my comments 🚀
# Conflicts: # CHANGELOG.md
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## main #2556 +/- ##
=========================================
Coverage 81.32% 81.33%
- Complexity 4192 4208 +16
=========================================
Files 336 337 +1
Lines 15489 15561 +72
Branches 2021 2031 +10
=========================================
+ Hits 12597 12657 +60
- Misses 2099 2110 +11
- Partials 793 794 +1
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report in Codecov by Sentry. |
# Conflicts: # CHANGELOG.md
romtsn
reviewed
Mar 27, 2023
# Conflicts: # CHANGELOG.md
Collaborator
Author
|
@romtsn A UI running on CI test seems to be flaky. AFAIK this should not be connected to this PR. Can we merge or is there something to do first? |
Member
merge it! |
Collaborator
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
📜 Description
nameproperty toUserGeoclassgeoproperty toUser💡 Motivation and Context
Relates to getsentry/sentry-dart#1065
💚 How did you test it?
Added unit tests
📝 Checklist
sendDefaultPIIis enabled.🔮 Next steps
Implement on cocoa and use in hybrid SDKs