Fix corrupted UUID on Motorola devices#2363
Merged
Merged
Conversation
romtsn
requested review from
adinauer,
markushi and
stefanosiano
as code owners
November 15, 2022 11:03
romtsn
force-pushed
the
fix/motorola-nil-uuid
branch
from
November 15, 2022 11:09
a99c362 to
b00e86b
Compare
Contributor
Performance metrics 🚀
|
| Revision | Plain | With Sentry | Diff |
|---|---|---|---|
| f809aac | 301.51 ms | 346.60 ms | 45.09 ms |
| a04f788 | 321.78 ms | 354.12 ms | 32.35 ms |
| 7597ded | 289.60 ms | 339.69 ms | 50.09 ms |
| 90e9745 | 314.68 ms | 357.28 ms | 42.60 ms |
| 38e4f11 | 358.20 ms | 433.73 ms | 75.53 ms |
App size
| Revision | Plain | With Sentry | Diff |
|---|---|---|---|
| f809aac | 1.73 MiB | 2.32 MiB | 608.63 KiB |
| a04f788 | 1.73 MiB | 2.32 MiB | 609.88 KiB |
| 7597ded | 1.73 MiB | 2.32 MiB | 609.88 KiB |
| 90e9745 | 1.73 MiB | 2.32 MiB | 608.63 KiB |
| 38e4f11 | 1.73 MiB | 2.32 MiB | 609.82 KiB |
Codecov ReportBase: 80.29% // Head: 80.31% // Increases project coverage by
Additional details and impacted files@@ Coverage Diff @@
## main #2363 +/- ##
============================================
+ Coverage 80.29% 80.31% +0.02%
- Complexity 3669 3672 +3
============================================
Files 290 290
Lines 13724 13727 +3
Branches 1809 1809
============================================
+ Hits 11019 11025 +6
+ Misses 2006 2005 -1
+ Partials 699 697 -2
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
markushi
approved these changes
Nov 15, 2022
7 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
📜 Description
We tested it with Bruno and indeed it returns a corrupted UUID on his device, no matter which method is used to instantiate the UUID:
So this is just a band aid for those cases
💡 Motivation and Context
Closes #2325
💚 How did you test it?
📝 Checklist
🔮 Next steps