fix: don't sent device name if DefaultPII is disabled#2354
Merged
Conversation
vaind
requested review from
adinauer,
markushi,
romtsn and
stefanosiano
as code owners
November 11, 2022 17:57
Contributor
Performance metrics 🚀
|
| Revision | Plain | With Sentry | Diff |
|---|---|---|---|
| f809aac | 301.51 ms | 346.60 ms | 45.09 ms |
| a04f788 | 321.78 ms | 354.12 ms | 32.35 ms |
| 7597ded | 289.60 ms | 339.69 ms | 50.09 ms |
| 90e9745 | 314.68 ms | 357.28 ms | 42.60 ms |
| 38e4f11 | 358.20 ms | 433.73 ms | 75.53 ms |
App size
| Revision | Plain | With Sentry | Diff |
|---|---|---|---|
| f809aac | 1.73 MiB | 2.32 MiB | 608.63 KiB |
| a04f788 | 1.73 MiB | 2.32 MiB | 609.88 KiB |
| 7597ded | 1.73 MiB | 2.32 MiB | 609.88 KiB |
| 90e9745 | 1.73 MiB | 2.32 MiB | 608.63 KiB |
| 38e4f11 | 1.73 MiB | 2.32 MiB | 609.82 KiB |
Codecov ReportBase: 80.36% // Head: 80.36% // No change to project coverage 👍
Additional details and impacted files@@ Coverage Diff @@
## main #2354 +/- ##
=========================================
Coverage 80.36% 80.36%
Complexity 3670 3670
=========================================
Files 290 290
Lines 13712 13712
Branches 1801 1801
=========================================
Hits 11020 11020
Misses 2001 2001
Partials 691 691 Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
adinauer
requested changes
Nov 14, 2022
adinauer
left a comment
adinauer
left a comment
Member
There was a problem hiding this comment.
Logic seems flipped. Could you please also add an entry to the changelog?
vaind
force-pushed
the
fix/skip-device-name
branch
from
November 14, 2022 08:15
1035e1c to
ddd3cf8
Compare
adinauer
approved these changes
Nov 14, 2022
romtsn
reviewed
Nov 14, 2022
romtsn
approved these changes
Nov 14, 2022
vaind
force-pushed
the
fix/skip-device-name
branch
from
November 14, 2022 08:29
ddd3cf8 to
d156d8a
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
📜 Description
💡 Motivation and Context
closes #2063
💚 How did you test it?
📝 Checklist