Update Spring Boot Jakarta to Spring Boot 3.0.0-RC2#2347
Merged
Conversation
This reverts commit cbf6abf.
Co-authored-by: Maciej Walkowiak <[email protected]> Co-authored-by: Lukas Bloder <[email protected]>
…ecations/removals
# Conflicts: # .github/workflows/build.yml # .github/workflows/format-code.yml # .github/workflows/generate-javadocs.yml # .github/workflows/integration-tests-benchmarks.yml # .github/workflows/integration-tests-ui.yml # CHANGELOG.md # buildSrc/src/main/java/Config.kt # sentry-android-integration-tests/sentry-uitest-android/src/androidTest/java/io/sentry/uitest/android/EnvelopeTests.kt # sentry-samples/sentry-samples-spring-boot-jakarta/build.gradle.kts # sentry-samples/sentry-samples-spring-boot-jakarta/src/main/java/io/sentry/samples/spring/boot/jakarta/PersonService.java # sentry-samples/sentry-samples-spring-boot-jakarta/src/main/java/io/sentry/samples/spring/boot/jakarta/SecurityConfiguration.java # sentry-samples/sentry-samples-spring-jakarta/build.gradle.kts # sentry-samples/sentry-samples-spring-jakarta/src/main/java/io/sentry/samples/spring/jakarta/SecurityConfiguration.java # sentry-spring-boot-starter-jakarta/build.gradle.kts # sentry-spring-boot-starter-jakarta/src/test/kotlin/io/sentry/spring/boot/jakarta/it/SentrySpringIntegrationTest.kt # sentry-spring-jakarta/build.gradle.kts # sentry-spring-jakarta/src/main/java/io/sentry/spring/jakarta/tracing/SentrySpanClientHttpRequestInterceptor.java # sentry-spring-jakarta/src/main/java/io/sentry/spring/jakarta/tracing/SentrySpanClientWebRequestFilter.java # sentry-spring-jakarta/src/main/java/io/sentry/spring/jakarta/webflux/SentryRequestResolver.java # sentry-spring-jakarta/src/main/java/io/sentry/spring/jakarta/webflux/SentryWebFilter.java # sentry-spring-jakarta/src/main/java/io/sentry/spring/jakarta/webflux/TransactionNameProvider.java # sentry-spring-jakarta/src/test/kotlin/io/sentry/spring/jakarta/mvc/SentrySpringIntegrationTest.kt
Contributor
|
lbloder
changed the title
# Conflicts: # CHANGELOG.md
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
| http.csrf().disable().authorizeRequests().anyRequest().authenticated().and().httpBasic(); | ||
| @Bean | ||
| public SecurityFilterChain filterChain(final @NotNull HttpSecurity http) throws Exception { | ||
| http.csrf().disable().authorizeHttpRequests().anyRequest().authenticated().and().httpBasic(); |
Check failure
Code scanning / CodeQL
Disabled Spring CSRF protection
| http.csrf().disable().authorizeRequests().anyRequest().authenticated().and().httpBasic(); | ||
| @Bean | ||
| public SecurityFilterChain filterChain(final @NotNull HttpSecurity http) throws Exception { | ||
| http.csrf().disable().authorizeHttpRequests().anyRequest().authenticated().and().httpBasic(); |
Check failure
Code scanning / CodeQL
Disabled Spring CSRF protection
…pringSecurity 6 RC2
adinauer
changed the title
adinauer
reviewed
Nov 11, 2022
adinauer
marked this pull request as ready for review
November 11, 2022 09:59
adinauer
approved these changes
Nov 11, 2022
Contributor
Performance metrics 🚀
|
| Revision | Plain | With Sentry | Diff |
|---|---|---|---|
| 90e9745 | 314.68 ms | 357.28 ms | 42.60 ms |
| a04f788 | 321.78 ms | 354.12 ms | 32.35 ms |
| f809aac | 301.51 ms | 346.60 ms | 45.09 ms |
| 7597ded | 289.60 ms | 339.69 ms | 50.09 ms |
App size
| Revision | Plain | With Sentry | Diff |
|---|---|---|---|
| 90e9745 | 1.73 MiB | 2.32 MiB | 608.63 KiB |
| a04f788 | 1.73 MiB | 2.32 MiB | 609.88 KiB |
| f809aac | 1.73 MiB | 2.32 MiB | 608.63 KiB |
| 7597ded | 1.73 MiB | 2.32 MiB | 609.88 KiB |
Codecov ReportBase: 80.36% // Head: 80.31% // Decreases project coverage by
Additional details and impacted files@@ Coverage Diff @@
## main #2347 +/- ##
============================================
- Coverage 80.36% 80.31% -0.06%
Complexity 3670 3670
============================================
Files 290 290
Lines 13712 13724 +12
Branches 1801 1809 +8
============================================
+ Hits 11020 11022 +2
- Misses 2001 2005 +4
- Partials 691 697 +6
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Co-authored-by: Maciej Walkowiak [email protected]
Co-authored-by: Lukas Bloder [email protected]
📜 Description
Update Spring Boot 3.0.0 to RC1, adapt code for removals and deprecations
💡 Motivation and Context
Expands on #1984 by upgrading from Spring Boot 3.0.0-M5 to RC2
💚 How did you test it?
📝 Checklist
🔮 Next steps