Fix NoSuchElementException in CircularFifoQueue when cloning a Scope#2328
Merged
Conversation
markushi
requested review from
adinauer,
romtsn and
stefanosiano
as code owners
November 2, 2022 16:14
Contributor
Performance metrics 🚀
|
romtsn
approved these changes
Nov 3, 2022
Member
|
Nice test 👍 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
📜 Description
Ensure that the breadcrumbs are copied in a thread safe manner when cloning a Scope.
💡 Motivation and Context
This fixes a top crash we saw in the Google Play SDK Console.
Related issues
If you know any better way to test this please let me know! (The test reliably crashed for me until I implemented the fix).
💚 How did you test it?
📝 Checklist
🔮 Next steps