Skip to content

Use correct set-cookie for the HTTP Client response object#2326

Merged
marandaneto merged 3 commits into
mainfrom
fix/cookie-response
Nov 2, 2022
Merged

Use correct set-cookie for the HTTP Client response object#2326
marandaneto merged 3 commits into
mainfrom
fix/cookie-response

Conversation

@marandaneto

@marandaneto marandaneto commented Nov 2, 2022

Copy link
Copy Markdown
Contributor

📜 Description

Use correct set-cookie for the HTTP Client response object

💡 Motivation and Context

https://developer.mozilla.org/en-US/docs/Web/HTTP/Headers/Set-Cookie

💚 How did you test it?

📝 Checklist

  • I reviewed the submitted code
  • I added tests to verify the changes
  • I updated the docs if needed
  • No breaking changes

🔮 Next steps

@github-actions

github-actions Bot commented Nov 2, 2022

Copy link
Copy Markdown
Contributor

Performance metrics 🚀

  Plain With Sentry Diff
Startup time 315.38 ms 344.60 ms 29.22 ms
Size 1.73 MiB 2.32 MiB 608.63 KiB

Baseline results on branch: main

Startup times

Revision Plain With Sentry Diff
90e9745 314.68 ms 357.28 ms 42.60 ms

App size

Revision Plain With Sentry Diff
90e9745 1.73 MiB 2.32 MiB 608.63 KiB

@marandaneto
marandaneto merged commit f809aac into main Nov 2, 2022
@marandaneto
marandaneto deleted the fix/cookie-response branch November 2, 2022 13:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants