Skip to content

Populate event.modules with dependencies metadata#2324

Merged
romtsn merged 13 commits into
mainfrom
feat/events-with-modules
Nov 4, 2022
Merged

Populate event.modules with dependencies metadata#2324
romtsn merged 13 commits into
mainfrom
feat/events-with-modules

Conversation

@romtsn

@romtsn romtsn commented Nov 2, 2022 •
edited
Loading

Copy link
Copy Markdown
Member

📜 Description

  • Adds platform-specific dependencies readers for Java and Android, that parse sentry-external-modules.txt file ingested by the gradle plugin into the final jar/apk
  • Sends those dependencies as part of every SentryEvent

💡 Motivation and Context

Closes #1470
Relates to getsentry/sentry-android-gradle-plugin#396
Part of getsentry/team-mobile#54

💚 How did you test it?

📝 Checklist

  • I reviewed the submitted code
  • I added tests to verify the changes
  • I updated the docs if needed
  • No breaking changes

🔮 Next steps

@romtsn romtsn changed the title Add dependencies file reader for Android and Java Populate event.modules with dependencies metadata Nov 2, 2022
@github-actions

github-actions Bot commented Nov 2, 2022 •
edited
Loading

Copy link
Copy Markdown
Contributor
Messages
📖 Do not forget to update Sentry-docs with your feature once the pull request gets approved.

Generated by 🚫 dangerJS against ae677c7

@github-actions

github-actions Bot commented Nov 2, 2022 •
edited
Loading

Copy link
Copy Markdown
Contributor

Performance metrics 🚀

  Plain With Sentry Diff
Startup time 306.62 ms 339.48 ms 32.86 ms
Size 1.73 MiB 2.32 MiB 609.84 KiB

Baseline results on branch: main

Startup times

Revision Plain With Sentry Diff
f809aac 301.51 ms 346.60 ms 45.09 ms
90e9745 314.68 ms 357.28 ms 42.60 ms

App size

Revision Plain With Sentry Diff
f809aac 1.73 MiB 2.32 MiB 608.63 KiB
90e9745 1.73 MiB 2.32 MiB 608.63 KiB

Previous results on branch: feat/events-with-modules

Startup times

Revision Plain With Sentry Diff
c39aba1 278.92 ms 344.45 ms 65.53 ms
2123a10 289.38 ms 332.15 ms 42.77 ms
a9f906d 303.51 ms 347.83 ms 44.32 ms
ed1e498 339.26 ms 385.94 ms 46.68 ms
6b29365 270.37 ms 291.50 ms 21.13 ms
6523b55 344.06 ms 372.39 ms 28.33 ms

App size

Revision Plain With Sentry Diff
c39aba1 1.73 MiB 2.32 MiB 609.83 KiB
2123a10 1.73 MiB 2.32 MiB 609.94 KiB
a9f906d 1.73 MiB 2.32 MiB 609.84 KiB
ed1e498 1.73 MiB 2.32 MiB 609.76 KiB
6b29365 1.73 MiB 2.32 MiB 610.00 KiB
6523b55 1.73 MiB 2.32 MiB 609.94 KiB

markushi
markushi approved these changes Nov 2, 2022
View reviewed changes

@markushi markushi left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice one, LGTM!

Comment thread ...-android-core/src/main/java/io/sentry/android/core/internal/modules/AssetsModulesLoader.java Outdated
Comment thread ...ndroid-core/src/test/java/io/sentry/android/core/internal/modules/AssetsModulesLoaderTest.kt Outdated
Comment thread sentry/src/test/java/io/sentry/internal/modules/ResourcesModulesLoaderTest.kt Outdated
marandaneto
marandaneto reviewed Nov 2, 2022
View reviewed changes
Comment thread sentry/src/main/java/io/sentry/MainEventProcessor.java
@codecov-commenter

codecov-commenter commented Nov 2, 2022 •
edited
Loading

Copy link
Copy Markdown

Codecov Report

Base: 80.25% // Head: 80.29% // Increases project coverage by +0.04% 🎉

Coverage data is based on head (ae677c7) compared to base (cc45d5c).
Patch coverage: 90.00% of modified lines in pull request are covered.

Additional details and impacted files 
@@             Coverage Diff              @@
##               main    #2324      +/-   ##
============================================
+ Coverage     80.25%   80.29%   +0.04%     
- Complexity     3479     3497      +18     
============================================
  Files           247      250       +3     
  Lines         12909    12969      +60     
  Branches       1735     1740       +5     
============================================
+ Hits          10360    10414      +54     
- Misses         1892     1897       +5     
- Partials        657      658       +1
Impacted Files Coverage Δ
sentry/src/main/java/io/sentry/SentryOptions.java 81.08% <75.00%> (-0.07%) ⬇️
...entry/internal/modules/ResourcesModulesLoader.java 80.00% <80.00%> (ø)
...java/io/sentry/internal/modules/ModulesLoader.java 92.30% <92.30%> (ø)
...ry/src/main/java/io/sentry/MainEventProcessor.java 84.89% <100.00%> (+1.04%) ⬆️
sentry/src/main/java/io/sentry/Sentry.java 54.49% <100.00%> (+0.78%) ⬆️
.../io/sentry/internal/modules/NoOpModulesLoader.java 100.00% <100.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@romtsn
romtsn merged commit 2826e76 into main Nov 4, 2022
@romtsn
romtsn deleted the feat/events-with-modules branch November 4, 2022 08:21
@G00fY2 G00fY2 mentioned this pull request Sep 25, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@markushi markushi markushi approved these changes
@adinauer adinauer Awaiting requested review from adinauer adinauer is a code owner
@stefanosiano stefanosiano Awaiting requested review from stefanosiano
+1 more reviewer
@marandaneto marandaneto marandaneto left review comments
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Populate event modules with dependencies metadata

4 participants

@romtsn @codecov-commenter @markushi @marandaneto