Release branch for pre-releasing 6.7#2307
Merged
Merged
Conversation
This reverts commit cbf6abf.
Co-authored-by: Maciej Walkowiak <[email protected]> Co-authored-by: Lukas Bloder <[email protected]>
Contributor
|
Contributor
Performance metrics 🚀
|
| Revision | Plain | With Sentry | Diff |
|---|---|---|---|
| f809aac | 301.51 ms | 346.60 ms | 45.09 ms |
| 90e9745 | 314.68 ms | 357.28 ms | 42.60 ms |
App size
| Revision | Plain | With Sentry | Diff |
|---|---|---|---|
| f809aac | 1.73 MiB | 2.32 MiB | 608.63 KiB |
| 90e9745 | 1.73 MiB | 2.32 MiB | 608.63 KiB |
Previous results on branch: feat/6.7.x
Startup times
| Revision | Plain | With Sentry | Diff |
|---|---|---|---|
| d55e277 | 310.20 ms | 329.74 ms | 19.54 ms |
| 843d929 | 341.48 ms | 378.30 ms | 36.82 ms |
| 3e6c9e5 | 297.19 ms | 340.93 ms | 43.75 ms |
App size
| Revision | Plain | With Sentry | Diff |
|---|---|---|---|
| d55e277 | 1.73 MiB | 2.32 MiB | 608.49 KiB |
| 843d929 | 1.73 MiB | 2.32 MiB | 607.06 KiB |
| 3e6c9e5 | 1.73 MiB | 2.32 MiB | 608.49 KiB |
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
| @Override | ||
| @SuppressWarnings("lgtm[java/spring-disabled-csrf-protection]") | ||
| protected void configure(final @NotNull HttpSecurity http) throws Exception { | ||
| http.csrf().disable().authorizeRequests().anyRequest().authenticated().and().httpBasic(); |
Check failure
Code scanning / CodeQL
Disabled Spring CSRF protection
| @Override | ||
| @SuppressWarnings("lgtm[java/spring-disabled-csrf-protection]") | ||
| protected void configure(final @NotNull HttpSecurity http) throws Exception { | ||
| http.csrf().disable().authorizeRequests().anyRequest().authenticated().and().httpBasic(); |
Check failure
Code scanning / CodeQL
Disabled Spring CSRF protection
Codecov ReportBase: 80.29% // Head: 80.36% // Increases project coverage by
Additional details and impacted files@@ Coverage Diff @@
## main #2307 +/- ##
============================================
+ Coverage 80.29% 80.36% +0.06%
- Complexity 3497 3670 +173
============================================
Files 250 290 +40
Lines 12969 13712 +743
Branches 1740 1801 +61
============================================
+ Hits 10414 11020 +606
- Misses 1897 2001 +104
- Partials 658 691 +33
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
adinauer
marked this pull request as ready for review
November 2, 2022 06:23
adinauer
requested review from
markushi,
romtsn and
stefanosiano
as code owners
November 2, 2022 06:23
romtsn
approved these changes
Nov 2, 2022
romtsn
left a comment
romtsn
left a comment
Member
There was a problem hiding this comment.
should be good, since I reviewed it already, but the checks are failing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
#skip-changelog
Merge when 6.7.0 becomes stable