Fix SentryFileWriter and SentryFileOutputStream append overwrites file contents#2304
Merged
Conversation
romtsn
requested review from
adinauer,
markushi and
stefanosiano
as code owners
October 17, 2022 19:16
romtsn
changed the title
Contributor
Performance metrics 🚀
|
| Revision | Plain | With Sentry | Diff |
|---|---|---|---|
| 2c5f172 | 310.20 ms | 357.16 ms | 46.96 ms |
| 3d89dea | 345.59 ms | 364.06 ms | 18.47 ms |
| 4dd88fe | 302.12 ms | 331.17 ms | 29.04 ms |
| 2c5f172 | 351.18 ms | 373.52 ms | 22.34 ms |
| d4087ee | 278.00 ms | 313.86 ms | 35.86 ms |
| 7300956 | 337.57 ms | 384.21 ms | 46.64 ms |
| 2f079a1 | 296.91 ms | 337.43 ms | 40.51 ms |
| 3d89dea | 322.38 ms | 350.82 ms | 28.45 ms |
| 2c5f172 | 289.18 ms | 307.56 ms | 18.38 ms |
| 4ca1d7b | 328.46 ms | 368.22 ms | 39.76 ms |
App size
| Revision | Plain | With Sentry | Diff |
|---|---|---|---|
| 2c5f172 | 1.73 MiB | 2.29 MiB | 580.10 KiB |
| 3d89dea | 1.74 MiB | 2.33 MiB | 604.92 KiB |
| 4dd88fe | 1.73 MiB | 2.29 MiB | 579.50 KiB |
| 2c5f172 | 1.73 MiB | 2.29 MiB | 580.10 KiB |
| d4087ee | 1.73 MiB | 2.29 MiB | 579.50 KiB |
| 7300956 | 1.73 MiB | 2.29 MiB | 578.69 KiB |
| 2f079a1 | 1.74 MiB | 2.33 MiB | 605.56 KiB |
| 3d89dea | 1.74 MiB | 2.33 MiB | 604.92 KiB |
| 2c5f172 | 1.73 MiB | 2.29 MiB | 580.10 KiB |
| 4ca1d7b | 1.73 MiB | 2.29 MiB | 579.88 KiB |
Codecov ReportBase: 80.11% // Head: 80.12% // Increases project coverage by
Additional details and impacted files@@ Coverage Diff @@
## main #2304 +/- ##
=========================================
Coverage 80.11% 80.12%
- Complexity 3433 3435 +2
=========================================
Files 242 242
Lines 12765 12769 +4
Branches 1703 1706 +3
=========================================
+ Hits 10227 10231 +4
Misses 1889 1889
Partials 649 649
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
adinauer
approved these changes
Oct 18, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
📜 Description
A very nasty bug 🙈
💡 Motivation and Context
Closes getsentry/sentry-android-gradle-plugin#387
💚 How did you test it?
With a unit test case
📝 Checklist
🔮 Next steps