fix(android): Remove verbose FrameMetricsAggregator failure logging#2293
Merged
Conversation
Contributor
Performance metrics 🚀
|
| Revision | Plain | With Sentry | Diff |
|---|---|---|---|
| 3d89dea | 322.38 ms | 350.82 ms | 28.45 ms |
| 7300956 | 324.20 ms | 353.79 ms | 29.58 ms |
| 4ca1d7b | 331.33 ms | 335.78 ms | 4.45 ms |
| 4dd88fe | 306.88 ms | 391.58 ms | 84.70 ms |
| 7300956 | 337.57 ms | 384.21 ms | 46.64 ms |
| 54cebc8 | 331.12 ms | 385.14 ms | 54.02 ms |
| c5ccd8a | 329.98 ms | 365.52 ms | 35.54 ms |
| 1e4690d | 354.69 ms | 387.88 ms | 33.19 ms |
| d4087ee | 278.00 ms | 313.86 ms | 35.86 ms |
| 4dd88fe | 302.12 ms | 331.17 ms | 29.04 ms |
App size
| Revision | Plain | With Sentry | Diff |
|---|---|---|---|
| 3d89dea | 1.74 MiB | 2.33 MiB | 604.92 KiB |
| 7300956 | 1.73 MiB | 2.29 MiB | 578.69 KiB |
| 4ca1d7b | 1.73 MiB | 2.29 MiB | 579.88 KiB |
| 4dd88fe | 1.73 MiB | 2.29 MiB | 579.50 KiB |
| 7300956 | 1.73 MiB | 2.29 MiB | 578.69 KiB |
| 54cebc8 | 1.73 MiB | 2.29 MiB | 579.43 KiB |
| c5ccd8a | 1.74 MiB | 2.33 MiB | 607.44 KiB |
| 1e4690d | 1.74 MiB | 2.33 MiB | 604.92 KiB |
| d4087ee | 1.73 MiB | 2.29 MiB | 579.50 KiB |
| 4dd88fe | 1.73 MiB | 2.29 MiB | 579.50 KiB |
romtsn
approved these changes
Oct 12, 2022
adinauer
approved these changes
Oct 12, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
📜 Description
Removes log output when calling the FrameMetricsAggregator fails.
💡 Motivation and Context
Right now any error when calling the FrameMetricsAggregator gets logged, including it's stacktrace. This can be confusing to the user, since we know FrameMetricsAggregator is expected to throw exceptions for various reasons.
Prior to 6.4.4 exceptions were swallowed, we should revert to that behavior.
Related issue: #2292
💚 How did you test it?
Ran tests.
📝 Checklist
🔮 Next steps