Concurrent profiling 2 - added list of transactions#2218
Merged
stefanosiano merged 5 commits intofeat/concurrent-profiling-datafrom Aug 31, 2022
Merged
Concurrent profiling 2 - added list of transactions#2218stefanosiano merged 5 commits intofeat/concurrent-profiling-datafrom
stefanosiano merged 5 commits intofeat/concurrent-profiling-datafrom
Conversation
…ofiling-logic # Conflicts: # sentry-android-core/src/main/java/io/sentry/android/core/AndroidTransactionProfiler.java
added unit/ui tests added CollectionUtils.map method
4 tasks
added unit/ui tests added CollectionUtils.map method
…at the last transaction has the same timestamp of the profile
Codecov Report
@@ Coverage Diff @@
## feat/concurrent-profiling-data #2218 +/- ##
====================================================================
- Coverage 80.45% 80.42% -0.04%
Complexity 3366 3366
====================================================================
Files 241 241
Lines 12416 12421 +5
Branches 1652 1653 +1
====================================================================
Hits 9989 9989
- Misses 1804 1809 +5
Partials 623 623
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
adinauer
approved these changes
Aug 31, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
📜 Description
We want to support concurrent transactions. In order to do it, we are going to add the list of transactions occurred during a profile.
This pr adds the list of transactions occurred during a profile to the data sent in the envelope payload.
This is the second part of concurrent profiling support, after this pr
💡 Motivation and Context
We want to avoid situations where the user cannot profile his transaction due to automatic transactions occurring at the same time, as pointed in this issue
The strategy we will follow is described here
💚 How did you test it?
Added unit test to check concurrent profiling logic
Added ui test to check the timestamps of transactions occurred during a profile
📝 Checklist
🔮 Next steps