Concurrent profiling 1 - added envelope payload data format#2216
Merged
stefanosiano merged 6 commits intomainfrom Sep 27, 2022
Merged
Concurrent profiling 1 - added envelope payload data format#2216stefanosiano merged 6 commits intomainfrom
stefanosiano merged 6 commits intomainfrom
Conversation
Codecov Report
@@ Coverage Diff @@
## main #2216 +/- ##
============================================
- Coverage 80.65% 80.45% -0.21%
- Complexity 3355 3366 +11
============================================
Files 240 241 +1
Lines 12324 12416 +92
Branches 1633 1652 +19
============================================
+ Hits 9940 9989 +49
- Misses 1778 1804 +26
- Partials 606 623 +17
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
stefanosiano
changed the title
stefanosiano
changed the title
stefanosiano
changed the title
4 tasks
Member
|
This PR has been sitting here for a while. @stefanosiano, how can we move this forward? Do you still need a review? |
Contributor
Author
In order to merge it i'm waiting for relay to be updated. |
adinauer
approved these changes
Aug 31, 2022
* added detection and recording of transactions occurred in a profile * added unit/ui tests * added CollectionUtils.map method
Contributor
Author
|
I'm going to wait for relay pr to be merged before merging this into master |
* added profile truncation reasons, "normal" by default * added uitest to check default profile truncation reason is "normal" * added unit test for truncation reason and updated another to remove a testOnly useless method
Contributor
Performance metrics 🚀
|
| Revision | Plain | With Sentry | Diff |
|---|---|---|---|
| 3d89dea | 345.59 ms | 364.06 ms | 18.47 ms |
| 1e4690d | 354.69 ms | 387.88 ms | 33.19 ms |
| 3d89dea | 322.38 ms | 350.82 ms | 28.45 ms |
| 2f079a1 | 296.91 ms | 337.43 ms | 40.51 ms |
App size
| Revision | Plain | With Sentry | Diff |
|---|---|---|---|
| 3d89dea | 1.74 MiB | 2.33 MiB | 604.92 KiB |
| 1e4690d | 1.74 MiB | 2.33 MiB | 604.92 KiB |
| 3d89dea | 1.74 MiB | 2.33 MiB | 604.92 KiB |
| 2f079a1 | 1.74 MiB | 2.33 MiB | 605.56 KiB |
Contributor
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
📜 Description
We want to support concurrent transactions. In order to do it, we are going to add the list of transactions occurred during a profile.
This pr just adds the data format of the transaction list that will be sent in the envelope payload, inserting the profiled transaction in it.
This is the first part of concurrent profiling support. Next part is this pr
💡 Motivation and Context
We want to avoid situations where the user cannot profile his transaction due to automatic transactions occurring at the same time, as pointed in this issue
The strategy we will follow is described here
💚 How did you test it?
Updated unit test to check the new format
Updated the ui test to check the current profiled transaction is added to the transaction list
📝 Checklist
🔮 Next steps
Another pr will contain the logic to add other transactions occurring during profiling