fix: update-gradle.sh#2195
Merged
Merged
Conversation
Codecov Report
@@ Coverage Diff @@
## main #2195 +/- ##
=========================================
Coverage 80.91% 80.91%
Complexity 3313 3313
=========================================
Files 236 236
Lines 12154 12154
Branches 1615 1615
=========================================
Hits 9834 9834
Misses 1725 1725
Partials 595 595 Continue to review full report at Codecov.
|
adinauer
approved these changes
Aug 2, 2022
marandaneto
reviewed
Aug 2, 2022
Comment on lines
+13
to
+16
| # Add trailing ".0" - gradlew outputs '7.1' instead of '7.1.0' | ||
| if [[ "$version" =~ ^[0-9]\.[0-9]$ ]]; then | ||
| version="$version.0" | ||
| fi |
Contributor
There was a problem hiding this comment.
Looking at https://github.com/gradle/gradle/releases/tag/v7.5.0
The tag is v7.5.0 but the command to update is:
./gradlew wrapper --gradle-version=7.5
Wouldn't that break our auto-updater?
Contributor
Author
There was a problem hiding this comment.
That's already trimmed below in set-version
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Ensures updater workflow doesn't fail because
./gradlew --versionreports a different version than the tag on github.com/gradle/gradle, when the tag ends with a zero.#skip-changelog