Fix thread leak due to Timer being created and never cancelled#2131
Merged
Conversation
Codecov Report
@@ Coverage Diff @@
## main #2131 +/- ##
=========================================
Coverage 80.93% 80.94%
- Complexity 3254 3257 +3
=========================================
Files 231 231
Lines 11951 11957 +6
Branches 1586 1588 +2
=========================================
+ Hits 9673 9679 +6
Misses 1698 1698
Partials 580 580
Continue to review full report at Codecov.
|
romtsn
reviewed
Jun 23, 2022
adinauer
commented
Jun 23, 2022
| this.hub = hub; | ||
| this.currentDateProvider = currentDateProvider; | ||
| if (enableSessionTracking) { | ||
| timer = new Timer(true); |
Member
Author
There was a problem hiding this comment.
not sure where we could call cancel on the timer here
romtsn
approved these changes
Jun 23, 2022
romtsn
left a comment
romtsn
left a comment
Member
There was a problem hiding this comment.
Tested on Android briefly, looked good, thanks for doing this!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
📜 Description
Timerwas created for every transaction which caused a new thread to be spawned each time. With this PR theTimeris only created inSentryTracerifidleTimeoutis set there. When the transaction is finished, the timer is cancelled.💡 Motivation and Context
Fixes #2115
💚 How did you test it?
📝 Checklist
🔮 Next steps