Filter out app starts with more than 60s#2127
Conversation
|
Oh cocoa the cutoff was 5 min. Is one value more likely to be legit than the other? |
No, Also 60s getsentry/sentry-cocoa#1899 |
…artState.java Co-authored-by: Alexander Dinauer <[email protected]>
…artState.java Co-authored-by: Alexander Dinauer <[email protected]>
| } | ||
|
|
||
| @Test | ||
| fun `getAppStartInterval returns null if more than 60s`() { |
There was a problem hiding this comment.
m: We could add another test with the max app start duration of 59999 ms to validate it is working correctly.
There was a problem hiding this comment.
I don't think this is unnecessary, we already test above and lower the boundary.
The comparison is a simple >= with a long value rather than some more complicated calculation.
I can do it but sounds like not needed, your call.
There was a problem hiding this comment.
If someone changes the MAX_APP_START_MILLIS to 10000000, no test will fail. Up to you.
Codecov Report
@@ Coverage Diff @@
## main #2127 +/- ##
=========================================
Coverage 80.93% 80.93%
Complexity 3254 3254
=========================================
Files 231 231
Lines 11951 11951
Branches 1586 1586
=========================================
Hits 9673 9673
Misses 1698 1698
Partials 580 580 Continue to review full report at Codecov.
|
…artState.java Co-authored-by: Alexander Dinauer <[email protected]>
5 participants
📜 Description
Filter out app starts with more than 60s
💡 Motivation and Context
getsentry/sentry-react-native#2295
💚 How did you test it?
📝 Checklist
🔮 Next steps