Conversation
4 tasks
adinauer
changed the title
Codecov Report
@@ Coverage Diff @@
## 6.x.x #2045 +/- ##
========================================
Coverage ? 81.06%
Complexity ? 3211
========================================
Files ? 229
Lines ? 11804
Branches ? 1568
========================================
Hits ? 9569
Misses ? 1650
Partials ? 585 Continue to review full report at Codecov.
|
Member
philipphofmann
left a comment
philipphofmann
left a comment
There was a problem hiding this comment.
Thanks for doing this. I only gave it a high level API review.
sentry-samples/sentry-samples-console/src/main/java/io/sentry/samples/console/Main.java
Outdated
Show resolved
Hide resolved
romtsn
approved these changes
May 19, 2022
* Store attachments in hints and allow manipulation in beforeSend and eventProcessor * Add changelog * Add tests for breadcrumbs and attachments via hints * Update CHANGELOG.md Co-authored-by: Philipp Hofmann <[email protected]> * Rename AttachmentContainer to Attachments * Use long for test * Move attachments into Hints * Fix kotlin/java interop for Hints * Convert screenshot from map entry to property * Rename hint name param * Rename clear to clearAttachments * Use kotlin short version access for getScreenshot * Move AttachmentsTest into HintsTest; add param names * Make primitiveMapping table static * Use ArrayList as there should not be a synchronization issue for hints Co-authored-by: Philipp Hofmann <[email protected]>
adinauer
commented
May 20, 2022
adinauer
commented
May 20, 2022
adinauer
commented
May 20, 2022
adinauer
commented
May 20, 2022
adinauer
commented
May 20, 2022
adinauer
commented
May 20, 2022
This was referenced May 23, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
📜 Description
Replaces
Map<String, Object>for hints with aHintsobject. Also changed from@Nullableto@NotNullinbeforeSendandEventProcessor.💡 Motivation and Context
This makes it easier for developers to interact with hints without having to deal with certain cases (e.g.
hints == null, hints not having an attachment entry, hints having a null attachment entry, ...)See getsentry/sentry-javascript#5036
Here's another PR building on top of this to allow manipulation of attachments via
beforeSendandeventProcessor: TODO💚 How did you test it?
Unit Tests, see linked PR
📝 Checklist
🔮 Next steps