Skip to content

Comments

Feat: Include unfinished spans in transaction.#1699

Merged
maciejwalkowiak merged 5 commits intomainfrom
gh-1690
Sep 6, 2021
Merged

Feat: Include unfinished spans in transaction.#1699
maciejwalkowiak merged 5 commits intomainfrom
gh-1690

Conversation

@maciejwalkowiak
Copy link
Contributor

@maciejwalkowiak maciejwalkowiak commented Sep 4, 2021 •
edited
Loading

📜 Description

Include unfinished spans in transaction

💡 Motivation and Context

Fixes #1690.

💚 How did you test it?

Unit tests.

📝 Checklist

  • I reviewed the submitted code
  • I added tests to verify the changes
  • I updated the docs if needed
  • No breaking changes

@maciejwalkowiak maciejwalkowiak marked this pull request as ready for review September 4, 2021 20:09
@codecov-commenter
Copy link

codecov-commenter commented Sep 4, 2021 •
edited
Loading

Codecov Report

Merging #1699 (258c133) into main (8dcd504) will decrease coverage by 0.02%.
The diff coverage is 56.25%.

Impacted file tree graph

@@             Coverage Diff              @@
##               main    #1699      +/-   ##
============================================
- Coverage     74.82%   74.80%   -0.03%     
+ Complexity     2078     2077       -1     
============================================
  Files           210      210              
  Lines          7428     7430       +2     
  Branches        782      782              
============================================
  Hits           5558     5558              
- Misses         1488     1491       +3     
+ Partials        382      381       -1
Impacted Files Coverage Δ
sentry/src/main/java/io/sentry/SentryClient.java 86.88% <ø> (-0.50%) ⬇️
sentry/src/main/java/io/sentry/SentryTracer.java 87.76% <41.66%> (-4.36%) ⬇️
sentry/src/main/java/io/sentry/Span.java 91.80% <100.00%> (+0.27%) ⬆️
...ain/java/io/sentry/protocol/SentryTransaction.java 89.65% <100.00%> (+3.44%) ⬆️
...y/src/main/java/io/sentry/protocol/SentrySpan.java 92.59% <0.00%> (-3.71%) ⬇️
sentry/src/main/java/io/sentry/Hub.java 74.45% <0.00%> (+1.37%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8dcd504...258c133. Read the comment docs.

marandaneto
marandaneto reviewed Sep 5, 2021
View reviewed changes
marandaneto
marandaneto reviewed Sep 5, 2021
View reviewed changes
marandaneto
marandaneto reviewed Sep 6, 2021
View reviewed changes
marandaneto
marandaneto approved these changes Sep 6, 2021
View reviewed changes
Copy link
Contributor

@marandaneto marandaneto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@maciejwalkowiak maciejwalkowiak merged commit 717ccad into main Sep 6, 2021
@maciejwalkowiak maciejwalkowiak deleted the gh-1690 branch September 6, 2021 08:04
@marandaneto marandaneto mentioned this pull request Sep 10, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@bruno-garcia bruno-garcia Awaiting requested review from bruno-garcia

1 more reviewer

@marandaneto marandaneto marandaneto approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Include unfinished spans in transactions

3 participants

@maciejwalkowiak @codecov-commenter @marandaneto