Conversation
limbonaut
force-pushed
the
sentry-godot-mobile-testing
branch
from
11b786a to
38b64ee
Compare
limbonaut
force-pushed
the
sentry-godot-mobile-testing
branch
2 times, most recently
from
e619430 to
a89e7d0
Compare
limbonaut
force-pushed
the
sentry-godot-mobile-testing
branch
from
5128a9d to
718535d
Compare
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
| [preset.0] | ||
|
|
||
| name="Android Tests" | ||
| platform="Android" |
There was a problem hiding this comment.
Commentary: Generated in Godot editor.
|
A chonky PR. Sorry, it's all related changes. |
limbonaut
requested review from
bitsandfoxes,
jpnurmi,
mujacica and
tustanivsky
| github "::endgroup::" | ||
|
|
||
| if [ $export_err -ne 0 ]; then | ||
| warning "Godot export process returned an error. Proceeding anyway..." |
There was a problem hiding this comment.
Does it make sense to proceed if export failed?
There was a problem hiding this comment.
Actually, yes. We additionally check on the presence of the export artifact later in script. Presently, if you look at CI logs, Godot tends to crash after exporting to Android is completed successfully, and it doesn't involve frames from our library. So the reason is unclear as we'd need some symbols to debug it, and I'll have opportunity to look closer into it after we get Godot builds going in getsentry/godot-builds.
There was a problem hiding this comment.
BTW, I couldn't reproduce it locally.
- Introduces a custom test runner, that can be executed directly from code, and bumps gdUnit4 to required commit. - Updates CI to use the new test runner, since it improves readability in GH logs with lots of output. - Adds a script to run tests on Android on a locally connected device. - Updates CI to run tests on Android emulator. - Adds a tool button to run tests straight from the demo project for convenience. - Adjusts tests for Android platform specifics, and removes mobile tests, which are no longer needed.
2 participants
This PR:
#skip-changelog