feat: Strip invisible characters from logger breadcrumbs#359
Merged
Conversation
Contributor
|
limbonaut
changed the title
Collaborator
Author
|
@sentry review |
![seer-by-sentry[bot]](https://avatars.githubusercontent.com/in/801464?s=60&v=4){kind=small}
limbonaut
requested review from
bitsandfoxes,
jpnurmi,
mujacica and
tustanivsky
jpnurmi
approved these changes
Sep 15, 2025
Collaborator
jpnurmi
left a comment
jpnurmi
left a comment
There was a problem hiding this comment.
Pity we have to process it all :(
Collaborator
Author
|
It needs to be processed somewhere in the chain, and I'm not sure if this should be upstreamed. Luckily, it doesn't seem to make much dent on performance: <1 usec with a long line on my system. |
tustanivsky
approved these changes
Sep 16, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Strip ASCII escape sequences and control characters from logger breadcrumbs. We're capturing Godot logger messages as breadcrumbs, and sometimes those messages contain unprintable control characters intended for terminal. Godot doesn't filter those sequences, hence this PR.
print_rich().