fix: UTF-8 retention problems with native SentryEvent properties#345
Merged
fix: UTF-8 retention problems with native SentryEvent properties#345
Conversation
limbonaut
changed the title
limbonaut
commented
Sep 3, 2025
| assert_str(event.get(property)).is_equal("Hello, World!") | ||
| event.set(property, "Hello 世界! 👋") | ||
| assert_str(event.get(property)).is_equal("Hello 世界! 👋") | ||
|
|
Collaborator
Author
There was a problem hiding this comment.
This replaces multiple tests removed below.
jpnurmi
approved these changes
Sep 3, 2025
Collaborator
jpnurmi
left a comment
jpnurmi
left a comment
There was a problem hiding this comment.
Are there any recursive dict/array conversions or such where the same problem could occur?
Collaborator
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR fixes issues with retaining UTF-8 encoding in native SentryEvent implementation, discovered while working on tests in #326. The problem is that getters should be using String::utf8() where we reasonably expect UTF-8. Extracted from #326.