Conversation
|
|
|
||
| sentry_uuid_t event_uuid; | ||
| if (p_feedback->get_associated_event_id().is_empty()) { | ||
| event_uuid = sentry_uuid_nil(); |
There was a problem hiding this comment.
is this a random uuid? If the id doesn't correspond to an error event the feedback won't be created in sentry, if you're using the old capture_user_feedback
There was a problem hiding this comment.
Thanks for bringing this up, I didn't realize it's a different protocol.
| p_feedback->get_contact_email().utf8(), | ||
| p_feedback->get_message().utf8()); | ||
|
|
||
| sentry_capture_user_feedback(uf); |
There was a problem hiding this comment.
why are we wrapping the old capture_user_feedback here? This will still send the old envelope format
There was a problem hiding this comment.
The Godot SDK is built on top of sentry-native, which doesn't yet have the new capture_feedback.
bruno-garcia
left a comment
bruno-garcia
left a comment
There was a problem hiding this comment.
We could add this first, though it must require an event id for it to work.
Or, add to sentry-native a capture_feedback
See:
| p_feedback->get_contact_email().utf8(), | ||
| p_feedback->get_message().utf8()); | ||
|
|
||
| sentry_capture_user_feedback(uf); |
There was a problem hiding this comment.
The Godot SDK is built on top of sentry-native, which doesn't yet have the new capture_feedback.
|
Indeed, if it just gets attached to an event, it's not as useful for what we have in mind. It needs more cooking then. |
|
Superseded by #418 |
3 participants
This PR adds API to capture user feedback. This API can be used to create user feedback forms in Godot games.
Needed for #170
TODOs:
before_capture_feedbackuser hook