fix(otel): Prefer http route over http target for span description - #1002
Merged
giortzisg merged 5 commits intoMay 9, 2025
Merged
Conversation
OrkhanAlikhanov
changed the title
Contributor
|
Can we also add some more tests for checking the fallback options and that they correctly parse the urls? @OrkhanAlikhanov |
Contributor
Author
|
Hello. Yes |
Contributor
Author
|
@giortzisg I added more test cases |
giortzisg
reviewed
Apr 30, 2025
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #1002 +/- ##
==========================================
+ Coverage 84.00% 84.99% +0.99%
==========================================
Files 50 50
Lines 5171 5173 +2
==========================================
+ Hits 4344 4397 +53
+ Misses 673 631 -42
+ Partials 154 145 -9 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Contributor
Author
|
Thank you @giortzisg. Looking forward to seeing it released |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #999