fix: Replace deprecated url.parse with parseStringToURLObject#1303
fix: Replace deprecated url.parse with parseStringToURLObject#1303AbhiPrasad merged 3 commits intomasterfrom
Conversation
Semver Impact of This PR🟢 Patch (bug fixes) 📋 Changelog PreviewThis is how your changes will appear in the changelog. Bug Fixes 🐛
🤖 This preview updates automatically when you update the PR. |
| @@ -42,16 +43,19 @@ export interface NetOptions { | |||
| * We want to match the final URL that Electron uses | |||
| */ | |||
| function parseOptions(optionsIn: ClientRequestConstructorOptions | string): { method: string; url: string } { | |||
There was a problem hiding this comment.
Maybe we can evaluate changing this all together?
There was a problem hiding this comment.
Probably! What would you change?
There was a problem hiding this comment.
not sure yet - but it seems like Electron itself also wants to change it? https://github.com/electron/electron/pull/48674/changes#r2466213286
Node.js 24+ (Electron 40+) emits deprecation warnings for url.parse() which get captured by captureConsoleIntegration and cause test failures. Replace url.parse() calls in net-breadcrumbs.ts with parseStringToURLObject from @sentry/core which uses the WHATWG URL API. Also updates e2e test versions to include Electron 40.0.0. Co-Authored-By: Claude Opus 4.5 <[email protected]>
AbhiPrasad
force-pushed
the
fix-url-parse-deprecation
branch
from
5de8f1b to
b2ffa30
Compare
|
Could the remaining |
|
It comes internally from Electron: |
|
I modified this PR to get the test passing with the latest version of Electron |
3 participants
Node.js 24+ (Electron 40+) emits deprecation warnings for url.parse() which get captured by captureConsoleIntegration and cause test failures.
Replace url.parse() calls in net-breadcrumbs.ts with parseStringToURLObject from @sentry/core which uses the WHATWG URL API.
Also updates e2e test versions to include Electron 40.0.0.