Merged
Conversation
AbhiPrasad
force-pushed
the
abhi-electron-ui-profiling
branch
from
f2f88b5 to
b145dbe
Compare
Contributor
Author
|
hmm @timfish any idea why the renderer e2e tests are failing here? |
Collaborator
|
Looks like flake since they passed on the third attempt 🤔 |
Contributor
Author
|
alright cool! This is ready for review now then. @timfish if you have a sufficiently complicated electron app, would be good to test this on that. My apps are all pretty simple so I don't know if there are cases where this could break. |
timfish
approved these changes
Nov 28, 2025
AbhiPrasad
added a commit
to getsentry/sentry-docs
that referenced
this pull request
Nov 28, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
resolves #1264
This PR adds support for UI profiling to Electron.
The
profilesSampleRateis now deprecated in favor ofprofileSessionSampleRate. The decisions if something should be profiled or not will now be made at SDK initialization (start of a user session on page load). And then, the whole user session will be continuously profiled.In
profileLifecycle: "manual"(default), users can start and stop profiling withSentry.uiProfiler.startProfiler()and.stopProfiler().In
profileLifecycle: "trace"the SDK automatically profiles when there is at least one active root/segment span. This is most similar to our previous transaction-based approach.