Merged
Conversation
![sentry[bot]](https://avatars.githubusercontent.com/in/12637?s=60&v=4){kind=small}
AbhiPrasad
force-pushed
the
abhi-electron-metrics
branch
from
2a56f20 to
69526e2
Compare
timfish
reviewed
Nov 18, 2025
| ## Unreleased | ||
|
|
||
| ## 7.3.0 | ||
|
|
Collaborator
There was a problem hiding this comment.
Looks like all the changes to this file are formatting
timfish
approved these changes
Nov 18, 2025
Collaborator
timfish
left a comment
timfish
left a comment
There was a problem hiding this comment.
LGTM if you can get the tests passing.
Looks like the SDK is not being overridden to Electron?
Contributor
Author
|
I wonder if these timeouts are related or just flakes 🤔 |
Collaborator
|
My guess would be timeouts since it's not impacting every os/version combo |
timfish
approved these changes
Nov 28, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
resolves #1263
https://docs.sentry.io/product/explore/metrics/
https://linear.app/getsentry/project/metrics-electron-b67f839c2d98/overview