Skip to content

Comments

fix: Only capture logs if enableLogs is true#1235

Merged
timfish merged 1 commit intomasterfrom
fix/only-capture-logs-when-enabled
Sep 11, 2025
Merged

fix: Only capture logs if enableLogs is true#1235
timfish merged 1 commit intomasterfrom
fix/only-capture-logs-when-enabled

Conversation

@timfish
Copy link
Collaborator

@timfish timfish commented Sep 11, 2025

Sone integrations now capture logs but this results in warnings being logged if logs are not enabled:

logging option not enabled, log will not be captured

This PR changes it so we only attempt to capture logs if enableLogs has been set to true.

@timfish timfish marked this pull request as ready for review September 11, 2025 15:05
@timfish timfish requested a review from AbhiPrasad September 11, 2025 15:05
@timfish timfish merged commit 3b6f2be into master Sep 11, 2025
110 of 127 checks passed
@timfish timfish deleted the fix/only-capture-logs-when-enabled branch September 11, 2025 22:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants