Skip to content

SentryMinidump: native crash report does not contain expected scope / context if a beforeSend function is supplied #481

@bowswung

Description

@bowswung

Versions + Platform

Description

As in title - if you supply a beforeSend function then the default SentryMinidump integration will not correctly fill in the scope on the event when sending a crash report.

This may be intentional, but I couldn't find docs stating this. The problematic line is this one - https://github.com/getsentry/sentry-electron/blob/master/src/main/integrations/sentry-minidump/index.ts#L234

which instead of giving the beforeSend function the newEvent that has been filled with scope, it passes the original event.

Fixing should be trivially to pass newEvent to beforeSend (we have patched this in locally and it seems to be working in the way we expect).

Metadata

Metadata

Assignees

Labels

No labels
No labels

Projects

No projects

Milestone

No milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions