fix: Multiple sentry.proguard-uuid being set in Android manifest#4647
Merged
alexsohn1126 merged 5 commits intomainfrom Oct 17, 2025
Merged
Conversation
alexsohn1126
changed the title
sentry.proguard-uuid being set in Android manifest
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #4647 +/- ##
==========================================
+ Coverage 73.45% 73.53% +0.07%
==========================================
Files 482 483 +1
Lines 17678 17692 +14
Branches 3493 3492 -1
==========================================
+ Hits 12986 13009 +23
+ Misses 3801 3795 -6
+ Partials 891 888 -3 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
alexsohn1126
requested review from
Flash0ver and
jamescrosswell
as code owners
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
This comment was marked as outdated.
This comment was marked as outdated.
Sorry, something went wrong.
Open
jamescrosswell
approved these changes
Oct 17, 2025
Collaborator
jamescrosswell
left a comment
jamescrosswell
left a comment
There was a problem hiding this comment.
Added one small recommendation but otherwise LGTM. 🚀
Thanks @alexsohn1126!
Co-authored-by: James Crosswell <[email protected]>
alexsohn1126
deleted the
alexsohn/fix/proguard-uuid-duplicate-in-android-manifest
branch
Member
|
@sentry review |
Member
|
after that pretty bad review comment from Cursor, I'm curious what Sentry will do here |
Member
|
I guess nothing because it has already been merged |
This was referenced Oct 31, 2025
This was referenced Nov 1, 2025
This was referenced Nov 10, 2025
This was referenced Nov 18, 2025
This was referenced Dec 8, 2025
This was referenced Dec 15, 2025
This was referenced Jan 18, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #4597
Problem
The setup described in #4597 is the following:
net9.0-androidThen the build will fail on
_ManifestMergerstep, due to the duplicated Android manifest metadatasentry.proguard-uuid.This was caused by
sentry.proguard-uuidbeing set up every time an Android project is built. So in the reproducible example above,sentry.proguard-uuidwould be set in Project A and B.Solution
I added a check to ensure
sentry.proguard-uuidis set only when the propertyAndroidApplicationis set totrue, which is set toTruefor MAUI apps, so when MSBuild gets to project B, it doesn't generate another UUID and tries to inject it to the Android manifest.See also:
Notes (feel free to ignore)
I have tried putting the
UpdateAndroidMetadatatarget into a separatesrc/Sentry/build/Sentry.targetsfile (to prevent the target from running transitively), but could not get it to work.If future problems arise where the
proguard-uuidis being set multiple times, we may need to consider that as a more permanent solution