Skip to content

Comments

ref(logs): remove ExperimentalAttribute and Experimental type from SentrySdk#4567

Merged
Flash0ver merged 6 commits intomainfrom
logs/partially-remove-experimental
Oct 1, 2025
Merged

ref(logs): remove ExperimentalAttribute and Experimental type from SentrySdk#4567
Flash0ver merged 6 commits intomainfrom
logs/partially-remove-experimental

Conversation

@Flash0ver
Copy link
Member

@Flash0ver Flash0ver commented Sep 25, 2025 •
edited by cursor bot
Loading

Remove

  • usages of [ExperimentalAttribute] from all Logs-APIs
  • Experimental type from SentrySdk

Keep

  • Experimental type on SentryOptions

Example

-#pragma warning disable SENTRY0001

 options.Experimental.EnableLogs = true;
 options.Experimental.SetBeforeSendLog(static log => log);

-SentrySdk.Experimental.Logger.LogInfo("message");
+SentrySdk.Logger.LogInfo("message");
HubAdapter.Instance.Logger.LogInfo("message");

-#pragma warning restore SENTRY0001

We think we are fine with the API shape, but still keep one Experimental (on SentryOptions) before we go officially stable.

Note

Removes experimental markers from Structured Logs APIs and replaces SentrySdk.Experimental.Logger with SentrySdk.Logger, updating adapters, samples, API approvals, and changelog while keeping SentryOptions.Experimental.

  • API Changes (Structured Logs):
    • Remove ExperimentalAttribute from SentryLog, SentryLogLevel, and SentryStructuredLogger methods, and from IHub.Logger/DisabledHub.Logger.
    • Replace SentrySdk.Experimental.Logger with new SentrySdk.Logger; remove SentrySdk.Experimental type; update HubAdapter.Logger to use SentrySdk.Logger.
    • Retain SentryOptions.Experimental (e.g., EnableLogs, SetBeforeSendLog).
  • Samples: Update usage to SentrySdk.Logger.* and adjust comments.
  • Tests/Approvals: Update API approval baselines to reflect non-experimental symbols and new SentrySdk.Logger.
  • Changelog: Add API Changes entry describing the de-experimentalization and SentrySdk.Logger switch.

Written by Cursor Bugbot for commit cc6733e. This will update automatically on new commits. Configure here.

@codecov
Copy link

codecov bot commented Sep 25, 2025 •
edited
Loading

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 73.47%. Comparing base (bc5c060) to head (cc6733e).
⚠️ Report is 7 commits behind head on main.

Additional details and impacted files 
@@            Coverage Diff             @@
##             main    #4567      +/-   ##
==========================================
+ Coverage   73.45%   73.47%   +0.02%     
==========================================
  Files         480      482       +2     
  Lines       17589    17679      +90     
  Branches     3469     3495      +26     
==========================================
+ Hits        12920    12990      +70     
- Misses       3785     3798      +13     
- Partials      884      891       +7

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@Flash0ver Flash0ver marked this pull request as ready for review September 26, 2025 06:43
Flash0ver
Flash0ver commented Sep 26, 2025
View reviewed changes
@Flash0ver
Copy link
Member Author

Flash0ver commented Sep 26, 2025

@sentry review

seer-by-sentry[bot]
seer-by-sentry bot reviewed Sep 26, 2025
View reviewed changes
alexsohn1126
alexsohn1126 reviewed Sep 26, 2025
View reviewed changes
Copy link
Member

@alexsohn1126 alexsohn1126 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a quick question...

jamescrosswell
jamescrosswell approved these changes Sep 28, 2025
View reviewed changes
Copy link
Collaborator

@jamescrosswell jamescrosswell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Flash0ver Flash0ver mentioned this pull request Sep 30, 2025
Merged
6 tasks
@Flash0ver Flash0ver merged commit 0c6ca6a into main Oct 1, 2025
35 checks passed
@Flash0ver Flash0ver deleted the logs/partially-remove-experimental branch October 1, 2025 09:30
@Flash0ver Flash0ver self-assigned this Oct 1, 2025
This was referenced Oct 2, 2025
Closed
Closed
Merged
Closed
Merged
Closed
Closed
Closed
Merged
Closed
This was referenced Oct 6, 2025
Merged
Merged
Closed
Merged
Closed
Closed
Merged
alexsohn1126 pushed a commit that referenced this pull request Oct 11, 2025
@Flash0ver @alexsohn1126
ref(logs): remove ExperimentalAttribute and Experimental type from Se…
f53d551 
…ntrySdk (#4567)
This was referenced Oct 13, 2025
Merged
Merged
Merged
This was referenced Oct 20, 2025
Closed
Closed
This was referenced Oct 28, 2025
Closed
Closed
Closed
Closed
Closed
Open
This was referenced Nov 18, 2025
Open
Open
This was referenced Dec 8, 2025
Closed
Closed
This was referenced Dec 15, 2025
Closed
Open
Closed
This was referenced Jan 18, 2026
Closed
Merged
Open
@dependabot dependabot bot mentioned this pull request Feb 16, 2026
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@alexsohn1126 alexsohn1126 alexsohn1126 left review comments

@seer-by-sentry seer-by-sentry[bot] seer-by-sentry[bot] left review comments

@jamescrosswell jamescrosswell jamescrosswell approved these changes

Assignees

@Flash0ver Flash0ver

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@Flash0ver @jamescrosswell @alexsohn1126